Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow outerclick to close import modal #28448

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Nov 13, 2024

Description

Clicking outside of modals is generally an assumed "now close the modal" interaction.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Open the Import Tokens modal
  2. Click the background
  3. See the modal go away

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner November 13, 2024 21:05
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [b800d6a]
Page Load Metrics (1815 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint50220981736309148
domContentLoaded16202063177211555
load16312108181513264
domInteractive137841168
backgroundConnect9164464220
firstReactRender4947714010048
getState45920189
initialActions00000
loadScripts11141507129110450
setupStore580222713
uiStartup182729122119274131
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -26 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing added this pull request to the merge queue Nov 14, 2024
Merged via the queue into develop with commit 12246e1 Nov 14, 2024
83 checks passed
@darkwing darkwing deleted the import-outer-click branch November 14, 2024 20:06
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants