Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [POM] Migrate onboarding metrics e2e tests to TS and Page Object Model to reduce flakiness #28424

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

chloeYue
Copy link
Contributor

@chloeYue chloeYue commented Nov 12, 2024

Description

  • Migrate onboarding metrics e2e tests to TS and Page Object Model
  • Use onboarding functions designed with Page Object Model, to reduce flakiness.

Open in GitHub Codespaces

Related issues

Fixes: #28425

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue self-assigned this Nov 12, 2024
@chloeYue chloeYue requested a review from a team as a code owner November 12, 2024 15:00
@chloeYue chloeYue marked this pull request as draft November 12, 2024 15:00
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [5c969fe]
Page Load Metrics (1969 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44323651877368177
domContentLoaded17632312193117685
load17722365196918488
domInteractive1885512110
backgroundConnect989352612
firstReactRender872931214723
getState56218189
initialActions01000
loadScripts12551738141314570
setupStore69012189
uiStartup193426332225215103
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue marked this pull request as ready for review November 12, 2024 17:19
@chloeYue chloeYue changed the title test: migrate onboarding metrics tests test: [POM] Migrate onboarding metrics e2e tests to TS and Page Object Model to reduce flakiness Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[POM] Migrate onboarding metrics e2e tests to use Page Object Model to reduce flakiness
2 participants