Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding e2e for signature decoding api #28423

Draft
wants to merge 3 commits into
base: native_value_display
Choose a base branch
from

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 12, 2024

Description

adding e2e for signature decoding api

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3625

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Nov 12, 2024
@jpuri jpuri requested review from a team as code owners November 12, 2024 13:50
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri marked this pull request as draft November 13, 2024 05:44
@jpuri
Copy link
Contributor Author

jpuri commented Nov 13, 2024

The PR can not be merged till the env variable are enabled for main build in develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant