Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix attribution generation #28415

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix: Fix attribution generation #28415

merged 2 commits into from
Nov 14, 2024

Commits on Nov 11, 2024

  1. fix: Fix attribution generation

    Fix the `attribution:generate` command by ensuring that it is possible
    to install just production dependencies.
    
    Previously the command `yarn workspaces focus --production` (used to
    discard development dependencies, keeping just production dependencies
    installed) would fail because `rimraf` was not found. `rimraf` was a
    development dependency used in the `postinstall` script. This was
    resolved by replacing `rimraf` with a Node.js script that does the
    same thing without needing any dependency.
    
    Once that failure was resolved, another was revealed. The
    `allow-scripts` step of the installation began failing because there
    was a package detected that had an install script that was missing from
    our configuration. This package was in our configuration already, but
    the `allow-scripts` configuration is sensitive to changes in the
    directory structure of `node_modules`, and that structure changed due
    to differences in which packages were hoisted in the production-only
    install.
    
    That failure was resolved by updating `generate-attributions.sh` to
    remove the `allow-scripts` plugin while generating attributions. We
    don't need `postinstall` scripts to run in order to read licences from
    disk.
    
    Fixes #28412
    Gudahtt committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e7c16f9 View commit details
    Browse the repository at this point in the history
  2. Update LavaMoat policies

    metamaskbot committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    838989e View commit details
    Browse the repository at this point in the history