Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update yarn to v4.5.1 #28365

Merged
merged 1 commit into from
Nov 8, 2024
Merged

build: update yarn to v4.5.1 #28365

merged 1 commit into from
Nov 8, 2024

Conversation

HowardBraham
Copy link
Contributor

@HowardBraham HowardBraham commented Nov 7, 2024

Description

Updates yarn to the latest v4.5.1, and adjusts LavaMoat policies to accommodate.

Open in GitHub Codespaces

@HowardBraham HowardBraham requested review from a team and kumavis as code owners November 7, 2024 18:41
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@HowardBraham HowardBraham self-assigned this Nov 7, 2024
@HowardBraham HowardBraham added the team-tiger Tiger team (for tech debt reduction + performance improvements) label Nov 7, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [c238f74]
Page Load Metrics (1841 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36524201769367176
domContentLoaded15972405180617584
load16112421184118388
domInteractive25190513718
backgroundConnect7107363014
firstReactRender492911015426
getState492192311
initialActions0442105
loadScripts11451939132216278
setupStore688202311
uiStartup181426412083246118
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The policy change suggests that Yarn updated its algorithm for when to hoist packages in node_modules. I see a couple of entries in their changelog related to this, so that makes sense. Not sure specifically which change caused this.

@HowardBraham HowardBraham added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Nov 8, 2024
Merged via the queue into develop with commit f3f6507 Nov 8, 2024
81 of 82 checks passed
@HowardBraham HowardBraham deleted the yarn-4.5.1 branch November 8, 2024 01:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants