Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert commit 3da34f4 (feat: btc e2e tests (#27986)) #28323

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Nov 6, 2024

This reverts commit 3da34f4.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr requested a review from a team as a code owner November 6, 2024 12:55
@metamaskbot
Copy link
Collaborator

Builds ready [7e6511e]
Page Load Metrics (2005 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51123561931349168
domContentLoaded17972299196512459
load18512361200512761
domInteractive16101602010
backgroundConnect1085412512
firstReactRender532891135526
getState57115178
initialActions01000
loadScripts13151765146512058
setupStore1184292110
uiStartup20342563225414167
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -279 Bytes (-0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gantunesr gantunesr added this pull request to the merge queue Nov 6, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [dbbc9e3]
Page Load Metrics (1957 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint54922171882340163
domContentLoaded16502151191415273
load16952223195716680
domInteractive198544168
backgroundConnect10114462813
firstReactRender542601175124
getState565262211
initialActions01000
loadScripts12161624141612460
setupStore1288332211
uiStartup18582615223620498
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -279 Bytes (-0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into develop with commit 6a54c99 Nov 6, 2024
76 checks passed
@gantunesr gantunesr deleted the revert/3da34f4 branch November 6, 2024 14:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants