Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(webpack): fix cache issues in webpack build by updating html-bundler-webpack-plugin to v4.4.1 #28225

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

davidmurdoch
Copy link
Contributor

Fixes #27831

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [59b1434]
Page Load Metrics (2022 ± 177 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28733181915522251
domContentLoaded159533011998373179
load160333172022369177
domInteractive14176473517
backgroundConnect86523157
firstReactRender46291964923
getState458262110
initialActions01000
loadScripts115327571500348167
setupStore117425209
uiStartup179835542241377181
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@davidmurdoch davidmurdoch force-pushed the update-html-bundler-webpack-plugin-again branch 2 times, most recently from 7ba144b to a99dfe5 Compare November 5, 2024 15:49
@davidmurdoch davidmurdoch force-pushed the update-html-bundler-webpack-plugin-again branch from a99dfe5 to f232bf4 Compare November 5, 2024 16:18
@davidmurdoch davidmurdoch marked this pull request as ready for review November 5, 2024 16:43
@davidmurdoch davidmurdoch requested a review from a team as a code owner November 5, 2024 16:43
@davidmurdoch davidmurdoch added webpack contributor experience An issue that impacts, or planned improvement to, the contributor experience. labels Nov 5, 2024
@davidmurdoch davidmurdoch changed the title build(webpack): fix cache issues in webpack build by updating html-bundler-webpack-plugin to v4.1.3 build(webpack): fix cache issues in webpack build by updating html-bundler-webpack-plugin to v4.4.1 Nov 5, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [f232bf4]
Page Load Metrics (1777 ± 75 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30522201706360173
domContentLoaded15202149175515373
load15282161177715675
domInteractive158143168
backgroundConnect771242010
firstReactRender492921074823
getState46110126
initialActions00000
loadScripts10701574129512359
setupStore1073282512
uiStartup17322422200117082
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@davidmurdoch davidmurdoch added this pull request to the merge queue Nov 6, 2024
Merged via the queue into develop with commit 201752e Nov 6, 2024
83 checks passed
@davidmurdoch davidmurdoch deleted the update-html-bundler-webpack-plugin-again branch November 6, 2024 16:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contributor experience An issue that impacts, or planned improvement to, the contributor experience. release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-extension-platform webpack
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

HTML bundler plugin fails to resolve source files
4 participants