chore: Bump Snaps packages #28215
Merged
chore: Bump Snaps packages #28215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
@SocketSecurity ignore npm/@metamask/snaps-sdk@6.10.0 This is ours. |
FrederikBolding
force-pushed
the
fb/snaps-bump-v75
branch
from
af17e13
to
f524c1e
Compare
Builds ready [94895b1]
Page Load Metrics (1904 ± 71 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
## **Description** Add changes to Snaps Address UI component to support more flexible use cases. This PR needs release of the `snaps-sdk` after merging: MetaMask/snaps#2833 [](https://codespaces.new/MetaMask/metamask-extension/pull/27798?quickstart=1) ## **Related issues** Fixes: MetaMask/snaps#2758 ## **Manual testing steps** 1. Use custom Snap build from template-snap-monorepo and add few varieties of address component to test new capabilities. 2. Make sure UI is looking good. 3. Make sure that there are no regressions. ## **Screenshots/Recordings** ### **Before**  ### **After**     ### Snap code used for testing #### (_Might be useful for QA_) ```typescript export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => { switch (request.method) { case 'hello': return snap.request({ method: 'snap_dialog', params: { type: 'confirmation', content: ( <Box> <Heading size="lg">Some unknown address</Heading> <Text>Default address</Text> <Address address="0x1acC6721CF7642Eb37651F8019AC9a785C064002" /> <Text>Custom address (displayName=true)</Text> <Address address="0x1acC6721CF7642Eb37651F8019AC9a785C064002" displayName={true} /> <Text>Custom address (avatar=false)</Text> <Address address="0x1234567890123456789012345678901234567890" avatar={false} /> <Text>Custom address (displayName=true, avatar=false)</Text> <Address address="0x1234567890123456789012345678901234567890" displayName={true} avatar={false} /> <Text>Custom address (truncate=false)</Text> <Address address="0x1234567890123456789012345678901234567890" truncate={false} /> <Text>Custom address (truncate=false, avatar=false)</Text> <Address address="0x1234567890123456789012345678901234567890" truncate={false} avatar={false} /> <Heading size="lg">My address</Heading> <Text>Default address</Text> <Address address="0xBc641D258aA0e90F70AaDbcC4dE2D58d88029713" /> <Text>Custom address (displayName=true)</Text> <Address address="0xBc641D258aA0e90F70AaDbcC4dE2D58d88029713" displayName={true} /> <Text>Custom address (avatar=false)</Text> <Address address="0xBc641D258aA0e90F70AaDbcC4dE2D58d88029713" avatar={false} /> <Text>Custom address (displayName=true, avatar=false)</Text> <Address address="0xBc641D258aA0e90F70AaDbcC4dE2D58d88029713" displayName={true} avatar={false} /> <Text>Custom address (truncate=false)</Text> <Address address="0xBc641D258aA0e90F70AaDbcC4dE2D58d88029713" truncate={false} /> <Text>Custom address (truncate=false, avatar=false)</Text> <Address address="0xBc641D258aA0e90F70AaDbcC4dE2D58d88029713" truncate={false} avatar={false} /> <Heading size="lg">Contact address</Heading> <Text>Default address</Text> <Address address="0x1acC6721CF7642Eb37651F8019AC9a785C064002" /> <Text>Custom address (displayName=true)</Text> <Address address="0x1acC6721CF7642Eb37651F8019AC9a785C064002" displayName={true} /> <Text>Custom address (avatar=false)</Text> <Address address="0x1acC6721CF7642Eb37651F8019AC9a785C064002" avatar={false} /> <Text>Custom address (displayName=true, avatar=false)</Text> <Address address="0x1acC6721CF7642Eb37651F8019AC9a785C064002" displayName={true} avatar={false} /> <Text>Custom address (truncate=false)</Text> <Address address="0x1acC6721CF7642Eb37651F8019AC9a785C064002" truncate={false} /> <Text>Custom address (truncate=false, avatar=false)</Text> <Address address="0x1acC6721CF7642Eb37651F8019AC9a785C064002" truncate={false} avatar={false} /> </Box> ), }, }); default: throw new Error('Method not found.'); } }; ``` ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Guillaume Roux <hello@guillaumerx.fr>
FrederikBolding
force-pushed
the
fb/snaps-bump-v75
branch
from
df64b2b
to
093caf7
Compare
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [093caf7]
Page Load Metrics (1843 ± 57 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Mrtenz
previously approved these changes
Nov 5, 2024
hmalik88
reviewed
Nov 5, 2024
| ? toChecksumHexAddress(parsed.address) | ||
| : parsed.address, | ||
| ); | ||
| // For EVM addresses, we make sure they are checksummed. |
](https://codespaces.new/MetaMask/metamask-extension/pull/27798?quickstart=1){kind=link}
There was a problem hiding this comment.
Hmm how come we aren't checksumming for non-evm (at least the one that we know about -- bitcoin)?
There was a problem hiding this comment.
We are assuming that Snaps take care of this part and won't build in special checksum logic for additional chains
hmalik88
previously approved these changes
Nov 5, 2024
hmalik88
approved these changes
Nov 5, 2024
Builds ready [da7906a]
Page Load Metrics (1846 ± 64 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Mrtenz
approved these changes
Nov 5, 2024
metamaskbot
added
the
release-12.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump Snaps packages and handle any required changes.
Summary of Snaps changes:
truncate,displayNameandavatarprops toAddresscomponentplatformVersionin the manifest and reject invalid versions when specified in stable