Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (cherry-pick): ignore warning for ethereumjs-wallet (#28145) #28155

Closed
wants to merge 5 commits into from

Commits on Oct 29, 2024

  1. chore: ignore warning for ethereumjs-wallet (#28145)

    ## **Description**
    
    To unblock develop, creating this PR that adds `ethereumjs-wallet` to
    list of deprecated packages that are ignored when using yarn audit. .
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28145?quickstart=1)
    
    ## **Related issues**
    
    Fixes:
    
    ## **Manual testing steps**
    
    1. Go to this page...
    2.
    3.
    
    ## **Screenshots/Recordings**
    
    <!-- If applicable, add screenshots and/or recordings to visualize the
    before and after of your change. -->
    
    ### **Before**
    
    <!-- [screenshots/recordings] -->
    
    ### **After**
    
    <!-- [screenshots/recordings] -->
    
    ## **Pre-merge author checklist**
    
    - [ ] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [ ] I've completed the PR template to the best of my ability
    - [ ] I’ve included tests if applicable
    - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [ ] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    sahar-fehri authored and danjm committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    20d5186 View commit details
    Browse the repository at this point in the history
  2. fix(deps): gridplus-sdk@2.5.1->~2.6.0 (#27973)

    - fix(deps): `gridplus-sdk@2.5.1->~2.6.0`
        - `2.7.0` updates to `@ethereumjs/tx` 5, so holding at 2.6
        - removes dependency on legacy `ethereum-cryptography` v1
    - dedupe and unpin `@ethereumjs/tx` to `^4.2.0`
      - `eth-lattice-keyring` is pinned to `@ethereumjs/tx@4.1.1`
      - `gridplus-sdk` is pinned to `@ethereumjs/tx@4.1.2`
    - fix(deps): bump `elliptic@6.5.4->^6.5.7` via resolutions
    - fix(deps): bump `secp256k`
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27973?quickstart=1)
    
    - GridPlus/eth-lattice-keyring#64
    - GridPlus/gridplus-sdk#547
    
    - [x] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [x] I've completed the PR template to the best of my ability
    - [x] I’ve included tests if applicable
    - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [x] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    legobeat authored and danjm committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8cb6cd6 View commit details
    Browse the repository at this point in the history
  3. Update LavaMoat policies

    metamaskbot committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    872470e View commit details
    Browse the repository at this point in the history
  4. fix(deps): gridplus-sdk@2.5.1->~2.6.0 (#27973)

    - fix(deps): `gridplus-sdk@2.5.1->~2.6.0`
        - `2.7.0` updates to `@ethereumjs/tx` 5, so holding at 2.6
        - removes dependency on legacy `ethereum-cryptography` v1
    - dedupe and unpin `@ethereumjs/tx` to `^4.2.0`
      - `eth-lattice-keyring` is pinned to `@ethereumjs/tx@4.1.1`
      - `gridplus-sdk` is pinned to `@ethereumjs/tx@4.1.2`
    - fix(deps): bump `elliptic@6.5.4->^6.5.7` via resolutions
    - fix(deps): bump `secp256k`
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27973?quickstart=1)
    
    - GridPlus/eth-lattice-keyring#64
    - GridPlus/gridplus-sdk#547
    
    - [x] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [x] I've completed the PR template to the best of my ability
    - [x] I’ve included tests if applicable
    - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [x] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    legobeat authored and danjm committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ae0c01c View commit details
    Browse the repository at this point in the history
  5. Update LavaMoat policies

    metamaskbot committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4ab6bb4 View commit details
    Browse the repository at this point in the history