Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (cherry-pick): added test network as selected network if globally selected for… #28139

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Oct 29, 2024

… connection Request (#27980)

This PR is to select a test network in the default selected networks list if its the globally selected network at the time of connection request.

Related issues

Fixes:
#27891 ## Manual testing steps

  1. Run extension with yarn start
  2. Switch to Sepolia
  3. Go to test-dapp, click on connect.
  4. In the connections page, check Sepolia is the selected along with non test networks
  5. Click confirm, dapp should be connected to MM and user should be on Sepolia network in MM.

Screenshots/Recordings

Before

Screen.Recording.2024-10-21.at.3.09.20.PM.mov

After

Screen.Recording.2024-10-21.at.3.07.23.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

… connection Request (#27980)

This PR is to select a test network in the default selected networks
list if its the globally selected network at the time of connection
request.

## **Related issues**

Fixes:
[#27891](#27891)
## **Manual testing steps**

1. Run extension with yarn start
2. Switch to Sepolia
3. Go to test-dapp, click on connect. 
4. In the connections page, check Sepolia is the selected along with non
test networks
5. Click confirm, dapp should be connected to MM and user should be on
Sepolia network in MM.

## **Screenshots/Recordings**


### **Before**



https://github.com/user-attachments/assets/127fc7bb-2e68-411a-b407-7f6d5158e911


### **After**



https://github.com/user-attachments/assets/dd0b5aa6-404a-421f-93a4-67cab43d60c6


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot
Copy link
Collaborator

Builds ready [1eb190f]
Page Load Metrics (2023 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32823881776625300
domContentLoaded16482252199218388
load165724012023208100
domInteractive16137532713
backgroundConnect9149404019
firstReactRender562981175024
getState573252311
initialActions00000
loadScripts11771726149716378
setupStore12118383215
uiStartup188130272312302145
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3.1 KiB (0.06%)
  • ui: 1.28 KiB (0.02%)
  • common: 284 Bytes (0.00%)

@darkwing darkwing changed the title feat: added test network as selected network if globally selected for… feat (cherry-pick): added test network as selected network if globally selected for… Oct 30, 2024
@danjm danjm merged commit ac1173b into Version-v12.6.0 Oct 30, 2024
81 of 82 checks passed
@danjm danjm deleted the Version-v12.6.0-connection-page-testnet branch October 30, 2024 21:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Oct 30, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.6.0 on PR, as PR was cherry-picked in branch 12.6.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants