-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (cherry-pick): added test network as selected network if globally selected for… #28139
Merged
danjm
merged 1 commit into
Version-v12.6.0
from
Version-v12.6.0-connection-page-testnet
Oct 30, 2024
Merged
feat (cherry-pick): added test network as selected network if globally selected for… #28139
danjm
merged 1 commit into
Version-v12.6.0
from
Version-v12.6.0-connection-page-testnet
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… connection Request (#27980) This PR is to select a test network in the default selected networks list if its the globally selected network at the time of connection request. ## **Related issues** Fixes: [#27891](#27891) ## **Manual testing steps** 1. Run extension with yarn start 2. Switch to Sepolia 3. Go to test-dapp, click on connect. 4. In the connections page, check Sepolia is the selected along with non test networks 5. Click confirm, dapp should be connected to MM and user should be on Sepolia network in MM. ## **Screenshots/Recordings** ### **Before** https://github.com/user-attachments/assets/127fc7bb-2e68-411a-b407-7f6d5158e911 ### **After** https://github.com/user-attachments/assets/dd0b5aa6-404a-421f-93a4-67cab43d60c6 ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
salimtb
approved these changes
Oct 29, 2024
Builds ready [1eb190f]
Page Load Metrics (2023 ± 100 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
darkwing
approved these changes
Oct 29, 2024
darkwing
changed the title
feat: added test network as selected network if globally selected for…
feat (cherry-pick): added test network as selected network if globally selected for…
Oct 30, 2024
jiexi
approved these changes
Oct 30, 2024
metamaskbot
added
the
release-12.6.0
Issue or pull request that will be included in release 12.6.0
label
Oct 30, 2024
No release label on PR. Adding release label release-12.6.0 on PR, as PR was cherry-picked in branch 12.6.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… connection Request (#27980)
This PR is to select a test network in the default selected networks list if its the globally selected network at the time of connection request.
Related issues
Fixes:
#27891 ## Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-10-21.at.3.09.20.PM.mov
After
Screen.Recording.2024-10-21.at.3.07.23.PM.mov
Pre-merge author checklist
Standards.
Pre-merge reviewer checklist
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist