Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: team-label-token #28134

Merged
merged 6 commits into from
Nov 6, 2024
Merged

feat: team-label-token #28134

merged 6 commits into from
Nov 6, 2024

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Oct 28, 2024

Description

Open in GitHub Codespaces

This PR updates the add-team-label job with the newly introduced TEAM_LABEL_TOKEN.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3545

Manual testing steps

  1. CI green with new token

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr self-assigned this Oct 28, 2024
@itsyoboieltr itsyoboieltr requested a review from a team as a code owner October 28, 2024 20:10
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@itsyoboieltr itsyoboieltr added the DO-NOT-MERGE Pull requests that should not be merged label Oct 28, 2024
@itsyoboieltr itsyoboieltr removed the DO-NOT-MERGE Pull requests that should not be merged label Oct 29, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [fadd744]
Page Load Metrics (2024 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17962446202916780
domContentLoaded17352268197715173
load17942347202415273
domInteractive20179583316
backgroundConnect12154524019
firstReactRender502901054924
getState567212311
initialActions01000
loadScripts12721686148011153
setupStore11104322713
uiStartup198329382273241116
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [c484e15]
Page Load Metrics (1807 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16712241180514971
domContentLoaded16232167177713464
load16742238180715474
domInteractive176738167
backgroundConnect108324209
firstReactRender493071035325
getState496162311
initialActions01000
loadScripts11871636131210852
setupStore1192372813
uiStartup183028482035244117
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@davidmurdoch davidmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it works!

@itsyoboieltr itsyoboieltr added this pull request to the merge queue Nov 6, 2024
Merged via the queue into develop with commit ef03946 Nov 6, 2024
76 checks passed
@itsyoboieltr itsyoboieltr deleted the feat/team-label-token branch November 6, 2024 16:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants