Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snaps): Remove arrows of custom UI inputs #27953

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Oct 18, 2024

Description

This PR removes the HTML arrows in custom UI inputs of type number.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

import {
  Box,
  Button,
  Container,
  Footer,
  Heading,
  Input,
  Text,
  type SnapComponent,
} from '@metamask/snaps-sdk/jsx';

/**
 * A custom dialog component.
 *
 * @returns The custom dialog component.
 */
export const CustomDialog: SnapComponent = () => (
  <Container>
    <Box>
      <Input name="number-input" type="number" />
    </Box>
    <Footer>
      <Button name="cancel">Cancel</Button>
      <Button name="confirm">Confirm</Button>
    </Footer>
  </Container>
);

Screenshots/Recordings

Before

Screenshot from 2024-10-18 13-00-54

After

Screenshot from 2024-10-18 12-57-41

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@GuillaumeRx GuillaumeRx marked this pull request as ready for review October 18, 2024 11:04
@GuillaumeRx GuillaumeRx requested a review from a team as a code owner October 18, 2024 11:04
david0xd
david0xd previously approved these changes Oct 18, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [c099817]
Page Load Metrics (1737 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1601189417338038
domContentLoaded1583184817027134
load1635189417378139
domInteractive188543189
backgroundConnect117536189
firstReactRender45202984220
getState766232110
initialActions01000
loadScripts1150136412365727
setupStore1099292613
uiStartup17932281194911656
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 211 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

david0xd
david0xd previously approved these changes Oct 18, 2024
hmalik88
hmalik88 previously approved these changes Oct 18, 2024
@GuillaumeRx GuillaumeRx dismissed stale reviews from hmalik88 and david0xd via b2b1d8c October 18, 2024 12:51
@GuillaumeRx GuillaumeRx changed the title fix(snaps): Remove arrows and use . for custom UI inputs fix(snaps): Remove arrows of custom UI inputs Oct 18, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [6407e2a]
Page Load Metrics (1914 ± 176 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46233581850491236
domContentLoaded15662468182320397
load157932931914366176
domInteractive1575432110
backgroundConnect108799519292
firstReactRender462121034723
getState4171203718
initialActions01000
loadScripts11201658134312560
setupStore11212504723
uiStartup176035342203482231
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@GuillaumeRx GuillaumeRx added this pull request to the merge queue Oct 19, 2024
Merged via the queue into develop with commit 4eaeb68 Oct 19, 2024
76 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/update-input-number-style branch October 19, 2024 10:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants