-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(snaps): Remove arrows of custom UI inputs #27953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
GuillaumeRx
force-pushed
the
gr/update-input-number-style
branch
from
October 18, 2024 11:04
3cc71bc
to
b7948a6
Compare
david0xd
previously approved these changes
Oct 18, 2024
Builds ready [c099817]
Page Load Metrics (1737 ± 39 ms)
Bundle size diffs
|
david0xd
previously approved these changes
Oct 18, 2024
hmalik88
previously approved these changes
Oct 18, 2024
FrederikBolding
requested changes
Oct 18, 2024
GuillaumeRx
changed the title
fix(snaps): Remove arrows and use
fix(snaps): Remove arrows of custom UI inputs
Oct 18, 2024
.
for custom UI inputs
FrederikBolding
approved these changes
Oct 18, 2024
GuillaumeRx
force-pushed
the
gr/update-input-number-style
branch
from
October 18, 2024 12:53
b2b1d8c
to
6407e2a
Compare
Builds ready [6407e2a]
Page Load Metrics (1914 ± 176 ms)
Bundle size diffs
|
david0xd
approved these changes
Oct 18, 2024
metamaskbot
added
the
release-12.8.0
Issue or pull request that will be included in release 12.8.0
label
Oct 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.8.0
Issue or pull request that will be included in release 12.8.0
team-snaps-platform
Snaps Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the HTML arrows in custom UI inputs of type
number
.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist