Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: margin on asset chart min/max indicators #27916

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Oct 17, 2024

Description

Design feedback that the min/max indicators on the asset chart should not be edge to edge like the chart itself. They should have margin like the rest of the content on the page.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Click on a token in the token list
  2. Click various date range buttons
  3. Verify min/max indicators on the chart are in right place
  4. Verify min/max indicators keep 16px margin from the edges

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron changed the title Update chart-tooltip.tsx fix: margin on asset chart min/max indicators Oct 17, 2024
gambinish
gambinish previously approved these changes Oct 17, 2024
Copy link
Contributor

@gambinish gambinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down and looks good to me 👍

I think this padding makes the graph look more center aligned somehow

@metamaskbot
Copy link
Collaborator

Builds ready [8c3addf]
Page Load Metrics (1855 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16312067185113565
domContentLoaded16052037182813063
load16342055185512661
domInteractive259352189
backgroundConnect138226188
firstReactRender47206943316
getState46318199
initialActions00000
loadScripts11161532133911555
setupStore1071262110
uiStartup17902369206516680
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 27 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@bergeron bergeron marked this pull request as ready for review November 1, 2024 22:09
@bergeron bergeron requested a review from a team as a code owner November 1, 2024 22:09
@metamaskbot
Copy link
Collaborator

Builds ready [c150d7a]
Page Load Metrics (1712 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15532066171211153
domContentLoaded15452057168910952
load15552066171211153
domInteractive21140482512
backgroundConnect108521209
firstReactRender4810688168
getState4371094
initialActions01000
loadScripts11131637125010752
setupStore96020178
uiStartup17002208189112058
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 27 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@bergeron bergeron added this pull request to the merge queue Nov 4, 2024
Merged via the queue into develop with commit 5e28e36 Nov 4, 2024
76 checks passed
@bergeron bergeron deleted the brian/chart-indicators-padding branch November 4, 2024 07:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants