-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct conditions for triggering name lookup during send #27880
Conversation
5276217
to
e6e2454
Compare
* Determines if a string is a possible ethereum address | ||
* | ||
* @param candidate - the input to check | ||
* @returns true if the input is a 40 char hex string with optional 0x prefix, false otherwise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Determines if a string is a possible ethereum address | |
* | |
* @param candidate - the input to check | |
* @returns true if the input is a 40 char hex string with optional 0x prefix, false otherwise | |
* Determine if a string is a possible Ethereum address. | |
* | |
* @param candidate - The input to check. | |
* @returns `true` if the input is a 40-character-long hex string with optional 0x-prefix, `false` otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is picked directly from develop
. I don't think it makes sense to improve it much in master
😄
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [0c9f4e8]
Page Load Metrics (1838 ± 89 ms)
|
Take changes from 5e08c06
Description
Hotfixes a problem preventing certain name resolution Snaps from being triggered due to faulty
IS_FLASK
conditions in12.4.1
. These conditions were removed in #26242. This PR picks these changes from the previously mentioned PR, without touching the ENS integration.The problem in question occurs when trying to trigger name resolution for a given input.
lookupDomainName
is never called on stable unless the input looks similar to an ENS name. This prevents resolution of inputs that don't use TLDs for instance.Manual testing steps
fc:frederik