Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dapp initiated token transfer #27875

Merged
merged 8 commits into from
Oct 18, 2024
Merged

feat: dapp initiated token transfer #27875

merged 8 commits into from
Oct 18, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Oct 15, 2024

Description

  • Implements new header for dapp initiated token transfer confirmations
  • Enables simulations component conditionally
  • Includes e2e tests for said confirmation

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3017

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screenshot 2024-10-15 at 16 20 37

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Oct 15, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Oct 15, 2024
@pedronfigueiredo pedronfigueiredo requested review from a team as code owners October 15, 2024 15:46
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

matthewwalsh0
matthewwalsh0 previously approved these changes Oct 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [57ee62c]
Page Load Metrics (1778 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26622161702360173
domContentLoaded15492199174814469
load15572219177814771
domInteractive19210625225
backgroundConnect875322211
firstReactRender6611490157
getState45515157
initialActions01000
loadScripts10981750129413766
setupStore976232110
uiStartup17322431196416177
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 8.88 KiB (0.12%)
  • common: 88 Bytes (0.00%)

Base automatically changed from pnf/3220 to develop October 17, 2024 13:41
@pedronfigueiredo pedronfigueiredo dismissed matthewwalsh0’s stale review October 17, 2024 13:41

The base branch was changed.

@metamaskbot
Copy link
Collaborator

Builds ready [c72a76b]
Page Load Metrics (2002 ± 107 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint42327631845516248
domContentLoaded16582591195318689
load167628012002224107
domInteractive31161502914
backgroundConnect7203475024
firstReactRender622831145024
getState997322813
initialActions01000
loadScripts11871962144015876
setupStore13106412914
uiStartup200134102306324156
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.63 KiB (0.03%)
  • common: 45 Bytes (0.00%)

jpuri
jpuri previously approved these changes Oct 17, 2024
vinistevam
vinistevam previously approved these changes Oct 18, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [aa40ae4]
Page Load Metrics (1859 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16752294186317283
domContentLoaded16652167180912259
load16742343185916981
domInteractive16144542613
backgroundConnect8314536833
firstReactRender45201993818
getState4156253919
initialActions01000
loadScripts1233160613559345
setupStore10209374521
uiStartup185036822125396190
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.63 KiB (0.03%)
  • common: 45 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Oct 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Oct 18, 2024
Merged via the queue into develop with commit 776bc1e Oct 18, 2024
76 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/3017 branch October 18, 2024 10:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants