-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(mock-e2e): add private domains logic for the privacy report #27844
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [d8a8c33]
Page Load Metrics (1947 ± 196 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, tested on 3e4c7c1
43ecfd2
to
bf370b6
Compare
Quality Gate passedIssues Measures |
Builds ready [bf370b6]
Page Load Metrics (1915 ± 94 ms)
Bundle size diffs
|
Description
Introduce the concept of "private domains" for the
privacy-snapshot.json
.This allow to hide some part of a host
Related issues
Required by:
Manual testing steps
yarn build:test:flask
metamask-extension/privacy-snapshot.json
Line 2 in d571550
yarn test:e2e:single test/e2e/flask/btc/btc-account-overview.spec.ts --browser=chrome --update-privacy-snapshot
privacy-snapshot.json
should have been updated again with the line you just removedScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist