Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(mock-e2e): add private domains logic for the privacy report #27844

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Oct 14, 2024

Description

Introduce the concept of "private domains" for the privacy-snapshot.json.

This allow to hide some part of a host

Open in GitHub Codespaces

Related issues

Required by:

Manual testing steps

  1. Use this PR to test the feature:
  1. yarn build:test:flask
  2. Remove the this line
    "*.btc*.quiknode.pro",
  3. yarn test:e2e:single test/e2e/flask/btc/btc-account-overview.spec.ts --browser=chrome --update-privacy-snapshot
  4. The privacy-snapshot.json should have been updated again with the line you just removed

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ccharly ccharly self-assigned this Oct 14, 2024
@ccharly ccharly requested a review from a team as a code owner October 14, 2024 16:57
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [d8a8c33]
Page Load Metrics (1947 ± 196 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint154031751930376180
domContentLoaded153122701835226108
load154132681947408196
domInteractive20198543919
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

montelaidev
montelaidev previously approved these changes Oct 15, 2024
Copy link
Contributor

@montelaidev montelaidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, tested on 3e4c7c1

@ccharly ccharly force-pushed the feat/privacy-snapshot-private-domains branch from 43ecfd2 to bf370b6 Compare October 15, 2024 16:25
Copy link

sonarcloud bot commented Oct 15, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [bf370b6]
Page Load Metrics (1915 ± 94 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16072357190718589
domContentLoaded15982344187218689
load16072424191519694
domInteractive19174553316
backgroundConnect10167403617
firstReactRender50269965225
getState58214199
initialActions01000
loadScripts11611915143018488
setupStore1280372412
uiStartup178726832144239115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@ccharly ccharly added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024
@ccharly ccharly added this pull request to the merge queue Oct 16, 2024
Merged via the queue into develop with commit 3f69851 Oct 16, 2024
78 checks passed
@ccharly ccharly deleted the feat/privacy-snapshot-private-domains branch October 16, 2024 09:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 16, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-accounts team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants