fix: SonarCloud for forks #27700

itsyoboieltr · 2024-10-08T14:15:41Z

Description

This PR fixes SonarCloud for forks.

Related issues

Fixes: #27135

Manual testing steps

SonarCloud analysis is successfully reported from a fork

Screenshots/Recordings

Not applicable

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-10-08T14:16:03Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-10-08T14:50:17Z

Builds ready [ef659fa]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1921 ± 68 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1705	2293	1918	132	63
		domContentLoaded	1655	2284	1874	140	67
		load	1706	2299	1921	141	68
		domInteractive	26	74	46	17	8

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-10-09T00:21:48Z

Builds ready [422b95e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1928 ± 161 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1567	3090	1927	337	162
		domContentLoaded	1521	3054	1900	329	158
		load	1562	3093	1928	335	161
		domInteractive	16	151	49	33	16

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

legobeat · 2024-10-09T06:04:31Z

Passing CI run targeting this branch: #27713

itsyoboieltr · 2024-10-09T10:43:05Z

@legobeat

If I understand correctly how workflow_run works, it is expected that SonarCloud does not run for this PR.

We need to use workflow_run, so that we can run SonarCloud for forks without exposing our sonar token
workflow_run is only triggered on the default branch. The changes are still on the feature branch, this means that SonarCloud won't be triggered.
We need to disable the checks, merge, and then see if the job is getting triggered or not.

metamaskbot · 2024-10-09T21:17:24Z

Builds ready [56d1c5a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1809 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	759	2216	1744	268	129
		domContentLoaded	1592	2072	1774	137	66
		load	1645	2232	1809	151	73
		domInteractive	18	86	42	18	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-10-10T06:46:52Z

Builds ready [ccc72b0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1797 ± 94 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	297	2203	1708	376	180
		domContentLoaded	1553	2179	1775	189	91
		load	1561	2272	1797	196	94
		domInteractive	25	78	44	15	7

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

HowardBraham · 2024-10-10T08:16:53Z

Oh whoops, this has to be manually force merged by an admin, because it's failing SonarCloud -- chicken and egg

NicholasEllul

Can we add a notice comment somewhere in this action along the lines of

This GitHub action will checkout and scan third party code. Please ensure that any changes to this action do not perform actions that may result in code from that branch being executed such as installing dependencies or running build scripts.

This will ensure that in the future we don't unintentionally introduce behaviour that may result in third party code being executed in the context of this workflow.

.github/workflows/sonarcloud.yml

Gudahtt

LGTM!

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

metamaskbot · 2024-10-16T20:59:08Z

Builds ready [6fed39b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1859 ± 204 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1511	3358	1869	408	196
		domContentLoaded	1491	2377	1760	228	109
		load	1500	3375	1859	426	204
		domInteractive	17	104	45	23	11
		backgroundConnect	8	999	104	219	105
		firstReactRender	46	246	96	54	26
		getState	5	169	38	44	21
		initialActions	0	1	0	0	0
		loadScripts	1062	1702	1306	169	81
		setupStore	10	282	42	64	31
		uiStartup	1697	4040	2178	672	323

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

jvbriones · 2024-10-28T10:47:55Z

.github/workflows/main.yml

    name: Run tests
    uses: ./.github/workflows/run-tests.yml

-  sonarcloud:


Hi @HowardBraham, why it was removed from the main workflow? we do want to analyze develop branch

itsyoboieltr requested a review from a team as a code owner October 8, 2024 14:15

github-actions bot added the team-extension-platform Extension Platform team label Oct 8, 2024

legobeat mentioned this pull request Oct 8, 2024

ci: trigger sonarcloud on fork (#27700) #27713

Closed

legobeat approved these changes Oct 8, 2024

View reviewed changes

legobeat requested a review from a team October 8, 2024 23:58

This comment was marked as resolved.

Sign in to view

legobeat previously approved these changes Oct 10, 2024

View reviewed changes

legobeat requested review from a team, HowardBraham and matthewwalsh0 October 10, 2024 07:43

HowardBraham previously approved these changes Oct 10, 2024

View reviewed changes

HowardBraham enabled auto-merge October 10, 2024 08:14

matthewwalsh0 previously approved these changes Oct 10, 2024

View reviewed changes

NicholasEllul reviewed Oct 10, 2024

View reviewed changes

itsyoboieltr dismissed stale reviews from matthewwalsh0, HowardBraham, and legobeat via 3ca355e October 10, 2024 17:37

itsyoboieltr requested review from Gudahtt, HowardBraham, NicholasEllul, legobeat and matthewwalsh0 October 10, 2024 17:39

itsyoboieltr dismissed stale reviews from legobeat and HowardBraham via e6b7619 October 16, 2024 18:32

itsyoboieltr requested review from HowardBraham, legobeat and rekmarks October 16, 2024 18:43

itsyoboieltr self-assigned this Oct 16, 2024

Gudahtt removed the DO-NOT-MERGE Pull requests that should not be merged label Oct 16, 2024

Gudahtt reviewed Oct 16, 2024

View reviewed changes

.github/workflows/sonarcloud.yml Outdated Show resolved Hide resolved

itsyoboieltr requested a review from Gudahtt October 16, 2024 19:30

Gudahtt reviewed Oct 16, 2024

View reviewed changes

.github/workflows/sonarcloud.yml Show resolved Hide resolved

Update sonarcloud.yml

0f34689

itsyoboieltr requested a review from Gudahtt October 16, 2024 19:39

Gudahtt reviewed Oct 16, 2024

View reviewed changes

.github/workflows/sonarcloud.yml Outdated Show resolved Hide resolved

Gudahtt previously approved these changes Oct 16, 2024

View reviewed changes

Update .github/workflows/sonarcloud.yml

6fed39b

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

legobeat dismissed Gudahtt’s stale review via 6fed39b October 16, 2024 20:26

legobeat approved these changes Oct 16, 2024

View reviewed changes

legobeat requested a review from Gudahtt October 16, 2024 20:40

legobeat requested a review from a team October 16, 2024 21:50

Gudahtt approved these changes Oct 16, 2024

View reviewed changes

HowardBraham added this pull request to the merge queue Oct 17, 2024

Merged via the queue into develop with commit 55d0972 Oct 17, 2024
76 checks passed

HowardBraham deleted the fix-sonarcloud-on-forks branch October 17, 2024 03:53

github-actions bot locked and limited conversation to collaborators Oct 17, 2024

metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 17, 2024

gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024

jvbriones reviewed Oct 28, 2024

View reviewed changes

fix: SonarCloud for forks #27700

fix: SonarCloud for forks #27700

Uh oh!

Conversation

itsyoboieltr commented Oct 8, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 8, 2024

Uh oh!

metamaskbot commented Oct 8, 2024

Uh oh!

metamaskbot commented Oct 9, 2024

Uh oh!

legobeat commented Oct 9, 2024

Uh oh!

This comment was marked as resolved.

itsyoboieltr commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Oct 9, 2024

Uh oh!

metamaskbot commented Oct 10, 2024

Uh oh!

HowardBraham commented Oct 10, 2024

Uh oh!

NicholasEllul left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gudahtt left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Oct 16, 2024

Uh oh!

Uh oh!

jvbriones Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

itsyoboieltr commented Oct 8, 2024 •

edited by github-actions bot

Loading

itsyoboieltr commented Oct 9, 2024 •

edited

Loading