test: [Snaps E2E] Unified methods and clean up snaps e2e tests #27684
+951
−338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowensanders
added
area-snaps
e2e-test
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Before there's any question about the added delays, all snaps tests failed test-e2e-firefox until the delays were reinstated. In an attempt to remain in method parity between all tests, documented delays have been added for all scrollTo actions. |
Builds ready [3bc665b]
Page Load Metrics (1746 ± 42 ms)
Bundle size diffs
|
FrederikBolding
previously approved these changes
Oct 8, 2024
hmalik88
reviewed
Oct 8, 2024
| const snapButton1 = await driver.findElement('#connectbip32'); | ||
| await driver.scrollToElement(snapButton1); | ||
|
|
||
| // added delay for firefox (deflake) | ||
| await driver.delay(1000); |
There was a problem hiding this comment.
Wondering if it's possible to conditionally add the delay for just firefox?
There was a problem hiding this comment.
Yes it is, and now is.
Added a function in driver.js called delayFirefox which only delays if firefox is the current browser.
hmalik88
reviewed
Oct 8, 2024
| await driver.delay(1000); | ||
|
|
||
| // wait for and click connect | ||
| await driver.waitForSelector('#connecterrors'); |
There was a problem hiding this comment.
I see you're doing this in some other tests so I'll just comment once. Why do we need to have both the waitForSelector call here with an increase in the delay?
There was a problem hiding this comment.
Well, because at first, it didn't hurt. In the case now, because those delays are "firefox specific" we need them for chrome instances.
bowensanders
force-pushed
the
bowen/snapsrehab
branch
from
970771e
to
94f1e6b
Compare
Builds ready [94f1e6b]
Page Load Metrics (1792 ± 74 ms)
Bundle size diffs
|
Builds ready [9b116f3]
Page Load Metrics (1796 ± 81 ms)
Bundle size diffs
|
Mrtenz
previously approved these changes
Oct 10, 2024
|
Delay: another round of changes i'm working on has to be finished before reviewing this code again. |
bowensanders
force-pushed
the
bowen/snapsrehab
branch
from
9b116f3
to
475660b
Compare
|
fixed merge error
Builds ready [dba0b52]
Page Load Metrics (2053 ± 155 ms)
Bundle size diffs
|
Builds ready [52b9b24]
Page Load Metrics (2117 ± 83 ms)
Bundle size diffs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because of several factors, over time, the E2E tests had diverged in their use of different methods to do the same thing. This PR represents work to unify these methods throughout the entire test base. It also was is an attempt to, as well as possible, document each individual step in the tests.
Some delays were removed in lieu of waitForSelector when appropriate.
Other delays were standardized. For example, Firefox requires delays to allow
scrollToElementto complete, hence the new Firefox Specific Delay™ has been added todriver.jsasdelayFirefox(time)because these delays are not reuired in Chrome instances.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist