fix: Fix unwanted IncompleteAssetDisplayed events

[OGPoyraz]

Description

This PR aims to stop IncompleteAssetDisplayed events appearing in the mix panel even the token is known by the API.

For more information please see the mixpanel link https://mixpanel.com/project/2212883/view/2760759/app/events#zy8pCckfmZvq

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3362

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[metamaskbot]

Builds ready [6f1f48e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2083 ± 88 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	266	2583	1904	561	269
		domContentLoaded	1810	2562	2049	172	83
		load	1820	2636	2083	183	88
		domInteractive	23	107	49	24	12

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 21 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [389e6ef]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2003 ± 132 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1709	2829	2001	271	130
		domContentLoaded	1669	2581	1959	235	113
		load	1706	2854	2003	276	132
		domInteractive	15	484	81	100	48
		backgroundConnect	9	244	44	59	28
		firstReactRender	57	179	103	29	14
		getState	4	164	25	39	19
		initialActions	0	1	0	0	0
		loadScripts	1216	1944	1474	201	96
		setupStore	11	165	43	41	20
		uiStartup	1911	3822	2279	459	220

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 21 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[matthewwalsh0]

We've other hooks below including a useEffect so would this condition best be added to the shouldSkipMetrics boolean that is checked inside the effect?

[OGPoyraz]

I think the way we trigger SimulationIncompleteAssetDisplayed is getting send regardless of that variable, it's not tied to transaction.

But now I noticed that useIncompleteAssetEvent not even cares if metrics are enabled or not 😄