Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed flaky test related to change language spec #27590

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
+14 −4
Draft

fix: Fixed flaky test related to change language spec #27590

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
76eef82
Fixed flaky test
hjetpoluru Oct 3, 2024
99416ed
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
hjetpoluru Oct 4, 2024
ccabfbd
Incorporated the changes suggested by seaona
hjetpoluru Oct 4, 2024
df9b75e
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
hjetpoluru Oct 4, 2024
635da09
Added wait before performing the action and removed additional wait
hjetpoluru Oct 9, 2024
71cd1aa
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
hjetpoluru Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions test/e2e/tests/settings/change-language.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,9 @@ describe('Settings - general tab @no-mmi', function (this: Suite) {
async ({ driver }: { driver: Driver }) => {
await unlockWallet(driver);
await changeLanguage(driver, languageIndex);
await driver.navigate();
await driver.clickElementAndWaitToDisappear(
'.settings-page__header__title-container__close-button',
);
await driver.clickElement(selectors.ethOverviewSend);
await driver.pasteIntoField(
selectors.ensInput,
Expand Down Expand Up @@ -176,7 +178,9 @@ describe('Settings - general tab @no-mmi', function (this: Suite) {
async ({ driver }: { driver: Driver }) => {
await unlockWallet(driver);
await changeLanguage(driver, languageIndex);
await driver.navigate();
await driver.clickElementAndWaitToDisappear(
'.settings-page__header__title-container__close-button',
);

// Validate the account tooltip
const isAccountTooltipChanged = await driver.isElementPresent(
Expand Down Expand Up @@ -214,7 +218,9 @@ describe('Settings - general tab @no-mmi', function (this: Suite) {
await unlockWallet(driver);
// selects "Magyar" language
await changeLanguage(driver, languageIndex);
await driver.navigate();
await driver.clickElementAndWaitToDisappear(
'.settings-page__header__title-container__close-button',
);
await driver.clickElement(selectors.nftsTab);

// Validate the hypertext
Expand Down
Loading