Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate MetaMask links into Snaps Link component #27377

Merged
merged 13 commits into from
Oct 4, 2024

Conversation

hmalik88
Copy link
Contributor

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change? Previously, developers couldn't navigate to parts of the extension with the existing functionality provided to them through snaps UI
  2. What is the improvement/solution? The Snaps Link component now checks for if the url is a MetaMask url and navigates to the proper path accordingly.

Screenshots/Recordings

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Sep 24, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 24, 2024
Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@hmalik88 hmalik88 changed the base branch from mrtenz/bump-snaps-packages to develop September 30, 2024 16:25
@hmalik88 hmalik88 changed the base branch from develop to mrtenz/bump-snaps-packages September 30, 2024 16:26
@hmalik88 hmalik88 changed the title Integrate MetaMask links into Snaps Link component feat: Integrate MetaMask links into Snaps Link component Sep 30, 2024
@hmalik88 hmalik88 changed the base branch from mrtenz/bump-snaps-packages to develop September 30, 2024 16:30
@hmalik88 hmalik88 changed the base branch from develop to mrtenz/bump-snaps-packages September 30, 2024 20:34
@hmalik88 hmalik88 marked this pull request as ready for review September 30, 2024 20:35
@hmalik88 hmalik88 requested review from a team as code owners September 30, 2024 20:35
Copy link
Contributor

@GuillaumeRx GuillaumeRx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@hmalik88 hmalik88 merged commit f375215 into mrtenz/bump-snaps-packages Oct 4, 2024
63 of 67 checks passed
@hmalik88 hmalik88 deleted the hm/integrate-metamask-links branch October 4, 2024 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants