Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch bridge quotes #27237

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

feat: fetch bridge quotes #27237

wants to merge 12 commits into from

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Sep 18, 2024

Description

Changes included:

  • bridge.utils.ts
    • add a method that makes requests to the bridge-api getQuotes endpoint
    • copy in bridge-api types
  • bridge-controller.ts
    • extend the StaticIntervalPollingController in order to poll the bridge-api for quotes
    • new state values for tracking active quoteRequest object
  • ui/pages/bridge/quotes/*
    • display recommended quote
    • add a placeholder modal for alternative quotes
  • fetch-with-timeout.ts
    • accept additional abort signals as arguments and apply them
  • reset bridge state on page load and unload
  • abort fetchQuote requests when inputs change or when page loads/unloads

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1448

Manual testing steps

  1. Request bridge quotes
  2. Click "Switch" button and verify that new quotes with updated params are requested/shown
  3. Verify that bridge parameters are reset when extension is reopened

Screenshots/Recordings

Before

N/A

After

Screen.Recording.2024-10-21.at.4.39.47.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae requested review from a team as code owners September 18, 2024 05:39
@micaelae micaelae marked this pull request as draft September 18, 2024 05:39
@micaelae micaelae changed the base branch from develop to mb890-src-and-dest-asset-pickers-backup-0828 September 18, 2024 05:40
@micaelae micaelae changed the base branch from mb890-src-and-dest-asset-pickers-backup-0828 to mb890-src-and-dest-asset-pickers-backup-0927 October 1, 2024 20:12
@micaelae micaelae changed the base branch from mb890-src-and-dest-asset-pickers-backup-0927 to mb890-src-and-dest-asset-pickers-backup-0828 October 1, 2024 20:13
Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@micaelae micaelae changed the base branch from mb890-src-and-dest-asset-pickers-backup-0828 to mb890-src-and-dest-asset-pickers-backup-0927 October 9, 2024 16:28
@micaelae micaelae removed request for a team October 9, 2024 16:34
@micaelae micaelae force-pushed the mb890-src-and-dest-asset-pickers-backup-0927 branch 2 times, most recently from 7c2f8e0 to 3222e6d Compare October 9, 2024 18:03
@micaelae micaelae force-pushed the mb890-src-and-dest-asset-pickers-backup-0927 branch from 3222e6d to 6506bef Compare October 9, 2024 18:22
@micaelae micaelae force-pushed the mb890-src-and-dest-asset-pickers-backup-0927 branch 4 times, most recently from 78bcf71 to 403d594 Compare October 10, 2024 22:06
@micaelae micaelae force-pushed the mb890-src-and-dest-asset-pickers-backup-0927 branch 2 times, most recently from 46529fe to fe7840e Compare October 15, 2024 22:23
@micaelae micaelae force-pushed the mb890-src-and-dest-asset-pickers-backup-0927 branch from fe7840e to 107470c Compare October 16, 2024 16:07
Base automatically changed from mb890-src-and-dest-asset-pickers-backup-0927 to develop October 16, 2024 16:50
@micaelae micaelae force-pushed the mb891-fetch-bridge-quotes branch 11 times, most recently from 27aa631 to a5688be Compare October 21, 2024 22:03
@micaelae micaelae force-pushed the mb891-fetch-bridge-quotes branch 2 times, most recently from 55aef81 to becd686 Compare October 21, 2024 23:39
@micaelae micaelae marked this pull request as ready for review October 21, 2024 23:42
@micaelae micaelae requested a review from a team as a code owner October 21, 2024 23:42
@micaelae micaelae requested a review from a team October 21, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant