-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(pom): cross-page chaining of page objects #27155
Open
dbrans
wants to merge
6
commits into
develop
Choose a base branch
from
djb/pom-base
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import { Driver } from '../../webdriver/driver'; | ||
| import { WALLET_PASSWORD } from '../../helpers'; | ||
| import { BasePage } from './base-page'; | ||
| import { HeaderNavbar } from './header-navbar'; | ||
| import { SettingsPage } from './settings-page'; | ||
| import HomePage from './homepage'; | ||
| import LoginPage from './login-page'; | ||
|
|
||
| // Top level page object for the app. | ||
| class App extends BasePage { | ||
| async getHeaderNavbar(): Promise<HeaderNavbar> { | ||
| // TODO: Ensure that the header navbar is visible. | ||
| return new HeaderNavbar(this.driver); | ||
| } | ||
|
|
||
| async getLoginPage(): Promise<LoginPage> { | ||
| return new LoginPage(this.driver).check_pageIsLoaded(); | ||
| } | ||
|
|
||
| async openSettings(): Promise<SettingsPage> { | ||
| const headerNavbar = await this.getHeaderNavbar(); | ||
| return headerNavbar.openSettings(); | ||
| } | ||
|
|
||
| async login(password: string = WALLET_PASSWORD): Promise<HomePage> { | ||
| const loginPage = await this.getLoginPage(); | ||
| return loginPage.login(password); | ||
| } | ||
| } | ||
|
|
||
| export const getApp = (driver: Driver): App => { | ||
| return new App(driver); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { Driver } from '../../webdriver/driver'; | ||
|
|
||
| export class BasePage { | ||
| protected driver: Driver; | ||
|
|
||
| constructor(driver: Driver) { | ||
| this.driver = driver; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,25 @@ | ||
| import { Driver } from '../../webdriver/driver'; | ||
| import { BasePage } from './base-page'; | ||
| import { SettingsPage } from './settings-page'; | ||
|
|
||
| class HeaderNavbar { | ||
| private driver: Driver; | ||
| export class HeaderNavbar extends BasePage { | ||
| private accountMenuButton: string = '[data-testid="account-menu-icon"]'; | ||
|
|
||
| private accountMenuButton: string; | ||
| private settingsMenuButton: string = '[data-testid="global-menu-settings"]'; | ||
|
|
||
| constructor(driver: Driver) { | ||
| this.driver = driver; | ||
| this.accountMenuButton = '[data-testid="account-menu-icon"]'; | ||
| } | ||
| private globalMenuButton: string = | ||
| '[data-testid="account-options-menu-button"]'; | ||
|
|
||
| async openAccountMenu(): Promise<void> { | ||
| await this.driver.clickElement(this.accountMenuButton); | ||
| } | ||
| } | ||
|
|
||
| export default HeaderNavbar; | ||
| async openGlobalMenu(): Promise<void> { | ||
| await this.driver.clickElement(this.globalMenuButton); | ||
| } | ||
|
|
||
| async openSettings(): Promise<SettingsPage> { | ||
| await this.openGlobalMenu(); | ||
| await this.driver.clickElement(this.settingsMenuButton); | ||
| return new SettingsPage(this.driver); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we really need to add this class. For the
getHeaderNavbar()andgetLoginPage()methods, we can create an instance ofHeaderNavbar()orLoginPage()directly when we need them. For theopenSettings(), we can donew HeaderNavbar(this.driver).openSettings()in tests. For the login method, I think the originalloginWithBalanceValidationis more straightforward and efficient enough.As page object model is in the adoption phase, we are trying to keep it as simple as possible to facilitate easier onboarding and usage.