-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(3210): deprecated Application open
metric event
#27102
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
211187a
to
eb123ce
Compare
eb123ce
to
bbb2420
Compare
Quality Gate passedIssues Measures |
Builds ready [bbb2420]
Page Load Metrics (1716 ± 105 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #27102 +/- ##
========================================
Coverage 70.11% 70.11%
========================================
Files 1425 1425
Lines 49692 49688 -4
Branches 13901 13900 -1
========================================
- Hits 34837 34835 -2
+ Misses 14855 14853 -2 ☔ View full report in Codecov by Sentry. |
Description
Refer to Slack thread, it is discovered that
Application Opened
event is only emitted during the on-boarding flow, not every time the application is opened. And further is discussed in this issue. In the end the decision made was to remove this event from codebase completelyRelated issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3210
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist