-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace Typography with Text component in signature-request-original.component.js #27076
base: develop
Are you sure you want to change the base?
Conversation
…-original.component.js
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@include design-system.H6; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing unneeded styles as this is covered by the Text
component https://github.com/MetaMask/metamask-extension/pull/27076/files#diff-0b1e3dca811d174401e32d4e02e4f70ebf269526c26c58f788cb7c3f0ee28ce0R216
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@include design-system.H3; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing unneeded styles as this is covered by the Text
component https://github.com/MetaMask/metamask-extension/pull/27076/files#diff-0b1e3dca811d174401e32d4e02e4f70ebf269526c26c58f788cb7c3f0ee28ce0R199
b3e6d5a
to
bd3c95a
Compare
@include design-system.H5; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing unneeded styles as this is covered by the Text
component https://github.com/MetaMask/metamask-extension/pull/27076/files#diff-0b1e3dca811d174401e32d4e02e4f70ebf269526c26c58f788cb7c3f0ee28ce0R228
@@ -122,8 +115,6 @@ | |||
} | |||
|
|||
&__row-value { | |||
@include design-system.H6; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing unneeded styles as this is covered by the Text
component https://github.com/MetaMask/metamask-extension/pull/27076/files#diff-0b1e3dca811d174401e32d4e02e4f70ebf269526c26c58f788cb7c3f0ee28ce0R233
bd3c95a
to
d5b7b4e
Compare
Quality Gate passedIssues Measures |
Description
This pull request replaces the
Typography
component with the newText
component in thesignature-request-original.component.js
file. This change is part of a larger effort to migrate from the oldTypography
component to the newText
component across the codebase.Text
component provides more flexibility and better alignment with our current design system.Devin Run Link : https://preview.devin.ai/devin/d07ca7670f6244788fb224fb91f54586
Related issues
Partially Fixes: #17670
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
This Devin run was requested by George.
If you have any feedback, you can leave comments in the PR and I'll address them in the app!