Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace Typography with Text component in signature-request-original.component.js #27076

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Sep 11, 2024

Description

This pull request replaces the Typography component with the new Text component in the signature-request-original.component.js file. This change is part of a larger effort to migrate from the old Typography component to the new Text component across the codebase.

  1. Reason for the change: To modernize our component usage and ensure consistency across the UI.
  2. Improvement/solution: The Text component provides more flexibility and better alignment with our current design system.

Devin Run Link : https://preview.devin.ai/devin/d07ca7670f6244788fb224fb91f54586

Open in GitHub Codespaces

Related issues

Partially Fixes: #17670

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Navigate to the SignatureRequestOriginal component
  3. Verify that the component renders correctly with the new Text component
  4. Check that all text elements maintain their previous styling and layout

Screenshots/Recordings

Before

Screenshot 2024-09-15 at 12 20 04 PM

After

Screenshot 2024-09-15 at 12 19 26 PM

Pre-merge author checklist

  • I've followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable
  • I've documented my code using JSDoc format if applicable
  • I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

This Devin run was requested by George.

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Extension team-ai AI team (for the Devin AI bot) and removed external-contributor labels Sep 11, 2024
Comment on lines -90 to -91
@include design-system.H6;

Copy link
Contributor

@georgewrmarshall georgewrmarshall Sep 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@georgewrmarshall georgewrmarshall Sep 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also removing unused styles as request-signature__warning classname doesn't exist

Screenshot 2024-09-15 at 12 22 27 PM

Comment on lines -53 to -54
@include design-system.H3;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines -115 to -116
@include design-system.H5;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -122,8 +115,6 @@
}

&__row-value {
@include design-system.H6;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarcloud bot commented Sep 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ai AI team (for the Devin AI bot) team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated Typography with Text component
1 participant