feat: ✨ show a notification item in the settings page #26843

matteoscurati · 2024-09-02T14:57:39Z

Description

This PR introduces the Notifications option within the settings page. Clicking on this option will render the user to the notifications/settings page.
Specifically:

If basic functionalities are not active, the option disappears from the menu
If notifications are not active, the user will still be redirected to the notifications/settings page, where they can enable them
If notifications are active, the user will access the notifications/settings page, where they can select their options

Related issues

N/A

Manual testing steps

Go to the settings page.
Find the Notifications option
Verify that the Notifications option links to the notifications/settings page
Verify that the Notifications option is hidden if basic functionalities are off

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-02T14:57:51Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-09-03T05:57:07Z

Builds ready [a272aca]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1821 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1639	2613	1821	207	100
		domContentLoaded	1619	2602	1805	208	100
		load	1627	2615	1821	209	101
		domInteractive	24	95	44	21	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 115 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-09-03T05:57:33Z

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.15%. Comparing base (7dc6362) to head (2911149).

Files with missing lines	Patch %	Lines
.../notifications-settings/notifications-settings.tsx	0.00%	1 Missing ⚠️
ui/pages/settings/settings.component.js	66.67%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26843      +/-   ##
===========================================
- Coverage    70.15%   70.15%   -0.00%     
===========================================
  Files         1425     1425              
  Lines        49653    49656       +3     
  Branches     13891    13892       +1     
===========================================
+ Hits         34833    34835       +2     
- Misses       14820    14821       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-09-10T15:33:14Z

Builds ready [1ca448e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1866 ± 208 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	341	3141	1794	560	269
		domContentLoaded	1486	3067	1857	432	208
		load	1491	3071	1866	432	208
		domInteractive	18	135	44	33	16

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 124 Bytes (0.00%)
common: 0 Bytes (0.00%)

sonarcloud · 2024-09-11T06:07:25Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-11T06:37:24Z

Builds ready [2911149]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1650 ± 74 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	606	1926	1583	263	126
		domContentLoaded	1380	1918	1631	154	74
		load	1388	1926	1650	154	74
		domInteractive	13	146	40	31	15

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 124 Bytes (0.00%)
common: 0 Bytes (0.00%)

Prithpal-Sooriya · 2024-09-13T09:50:43Z

ui/pages/notifications-settings/notifications-settings.tsx

@@ -82,7 +81,7 @@ export default function NotificationsSettings() {
            ariaLabel="Back"
            iconName={IconName.ArrowLeft}
            size={ButtonIconSize.Sm}
-            onClick={() => history.push(NOTIFICATIONS_ROUTE)}
+            onClick={() => history.go(-1)}


I don't see this used elsewhere in extension.
Can we use history.back()?

ui/pages/settings/settings.component.js

feat: ✨ show a notification item in the settings page

ffa2de7

matteoscurati added the team-notifications Notifications team label Sep 2, 2024

matteoscurati added 2 commits September 2, 2024 17:09

Merge branch 'develop' into feat/settings-page-add-notifications

0187de7

Merge branch 'develop' into feat/settings-page-add-notifications

a272aca

Merge branch 'develop' into feat/settings-page-add-notifications

5d376ee

matteoscurati marked this pull request as ready for review September 10, 2024 14:34

matteoscurati requested review from a team as code owners September 10, 2024 14:34

matteoscurati force-pushed the feat/settings-page-add-notifications branch 2 times, most recently from 8e62d16 to 5d376ee Compare September 10, 2024 15:00

feat: ✨ use the right icon

1ca448e

Merge branch 'develop' into feat/settings-page-add-notifications

2911149

Prithpal-Sooriya reviewed Sep 13, 2024

View reviewed changes

ui/pages/settings/settings.component.js Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ✨ show a notification item in the settings page #26843

feat: ✨ show a notification item in the settings page #26843

matteoscurati commented Sep 2, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Sep 2, 2024

metamaskbot commented Sep 3, 2024

codecov bot commented Sep 3, 2024 •

edited

Loading

metamaskbot commented Sep 10, 2024

sonarcloud bot commented Sep 11, 2024

metamaskbot commented Sep 11, 2024

Prithpal-Sooriya Sep 13, 2024

feat: ✨ show a notification item in the settings page #26843

Are you sure you want to change the base?

feat: ✨ show a notification item in the settings page #26843

Conversation

matteoscurati commented Sep 2, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 2, 2024

metamaskbot commented Sep 3, 2024

codecov bot commented Sep 3, 2024 • edited Loading

Codecov Report

metamaskbot commented Sep 10, 2024

sonarcloud bot commented Sep 11, 2024

Quality Gate passed

metamaskbot commented Sep 11, 2024

Prithpal-Sooriya Sep 13, 2024

Choose a reason for hiding this comment

matteoscurati commented Sep 2, 2024 •

edited by github-actions bot

Loading

codecov bot commented Sep 3, 2024 •

edited

Loading