Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert breaking change to requests with null ids (#26143) #26814

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Aug 30, 2024

Description

Fixes issue introduced by: #26143, #26626

  • Revert breaking change to requests with null IDs handled by createDupeReqFilterStream.
  • Remove outdated yarn patch for @trezor/connect-web@9.2.2.
  • Assign type for getInitialSendStateWithExistingTxState param.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MajorLift MajorLift self-assigned this Aug 30, 2024
@MajorLift MajorLift requested a review from a team as a code owner August 30, 2024 14:05
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (c5cbdf0) to head (7fdc72f).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26814   +/-   ##
========================================
  Coverage    70.13%   70.13%           
========================================
  Files         1417     1417           
  Lines        49444    49444           
  Branches     13835    13834    -1     
========================================
  Hits         34676    34676           
  Misses       14768    14768           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [0bf4708]
Page Load Metrics (1869 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint20821151627597287
domContentLoaded15692102184312962
load15802117186911857
domInteractive137433167
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -13 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Aug 30, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [7fdc72f]
Page Load Metrics (1701 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24720171552456219
domContentLoaded14782035167015474
load15182038170116579
domInteractive127834178
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -13 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@MajorLift MajorLift requested review from a team September 3, 2024 20:30
Copy link
Contributor

@kanthesha kanthesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MajorLift MajorLift merged commit 9f07ef5 into develop Sep 4, 2024
78 checks passed
@MajorLift MajorLift deleted the fix/eth-json-rpc-middleware@14.0.0-follow-up branch September 4, 2024 12:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 4, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants