-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert breaking change to requests with null
ids (#26143)
#26814
fix: revert breaking change to requests with null
ids (#26143)
#26814
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26814 +/- ##
========================================
Coverage 70.13% 70.13%
========================================
Files 1417 1417
Lines 49444 49444
Branches 13835 13834 -1
========================================
Hits 34676 34676
Misses 14768 14768 ☔ View full report in Codecov by Sentry. |
Builds ready [0bf4708]
Page Load Metrics (1869 ± 57 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedIssues Measures |
Builds ready [7fdc72f]
Page Load Metrics (1701 ± 79 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
Fixes issue introduced by: #26143, #26626
null
IDs handled bycreateDupeReqFilterStream
.@trezor/connect-web@9.2.2
.getInitialSendStateWithExistingTxState
param.Related issues
@metamask/eth-json-rpc-middleware
to^14.0.0
,@metamask/transaction-controller
to^35.1.1
#26143@metamask/eth-json-rpc-middleware
to^14.0.0
(#26143) #26626Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist