fix: Show correct origins when snaps use `wallet_requestSnaps` #26715

hmalik88 · 2024-08-28T14:14:06Z

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

What is the reason for the change? We are allowing wallet_requestSnaps to be called by other snaps and needed to update the UI to correctly show the snap origin.
What is the improvement/solution? There needed to be some UI changes to accommodate the above.

Related issues

Fixes MetaMask/snaps#2611

Screenshots/Recordings

Before

After

Screen.Recording.2024-08-27.at.3.00.52.PM.mov

NOTE: The copy was updated to "Connected Snaps" and "Connected sites and Snaps".

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-08-28T14:14:16Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-08-28T15:17:23Z

Builds ready [8e9f0c5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (69 ± 9 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	63	137	91	19	9
		domContentLoaded	39	114	65	18	9
		load	46	121	69	18	9
		domInteractive	9	84	24	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 779 Bytes (0.01%)
common: 104 Bytes (0.00%)

codecov · 2024-08-28T16:01:36Z

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.16%. Comparing base (ce04ae8) to head (ba5453a).

Files with missing lines	Patch %	Lines
...ected-sites-list/connected-sites-list.component.js	72.73%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26715      +/-   ##
===========================================
+ Coverage    70.14%   70.16%   +0.02%     
===========================================
  Files         1424     1425       +1     
  Lines        49572    49580       +8     
  Branches     13868    13869       +1     
===========================================
+ Hits         34769    34787      +18     
+ Misses       14803    14793      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-08-28T16:15:04Z

Builds ready [99ffde8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1808 ± 93 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	211	2219	1734	392	188
		domContentLoaded	1525	2176	1769	172	82
		load	1566	2231	1808	194	93
		domInteractive	12	69	35	17	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 779 Bytes (0.01%)
common: 104 Bytes (0.00%)

ui/pages/permissions-connect/snaps/snaps-connect/snaps-connect.js

FrederikBolding

LGTM - but please update the PR title to be more accurate to the changes in the PR!

ui/pages/snaps/snap-view/snap-settings.js

ui/pages/permissions-connect/snaps/snaps-connect/snaps-connect.js

ui/components/app/snaps/snap-metadata-modal/snap-metadata-modal.js

ui/pages/permissions-connect/snaps/snaps-connect/snaps-connect.js

ui/pages/snaps/snap-view/snap-settings.js

metamaskbot · 2024-09-02T19:10:06Z

Builds ready [53f11f8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1718 ± 87 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	218	2202	1582	480	231
		domContentLoaded	1492	2193	1701	184	89
		load	1500	2203	1718	182	87
		domInteractive	12	203	40	39	19

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.37 KiB (0.02%)
common: 104 Bytes (0.00%)

metamaskbot · 2024-09-03T15:34:58Z

Builds ready [3a8b268]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1951 ± 83 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	212	2283	1713	624	299
		domContentLoaded	1694	2238	1930	164	79
		load	1702	2284	1951	174	83
		domInteractive	17	72	39	14	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.75 KiB (0.05%)
common: 104 Bytes (0.00%)

sonarcloud · 2024-09-03T15:42:00Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-03T16:10:54Z

Builds ready [ba5453a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1807 ± 84 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	301	2026	1571	476	229
		domContentLoaded	1549	2220	1786	167	80
		load	1561	2271	1807	174	84
		domInteractive	15	172	38	33	16

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.79 KiB (0.05%)
common: 104 Bytes (0.00%)

hmalik88 added 2 commits August 27, 2024 17:44

update UI to properly show snap info when installing another snap

412521a

Merge branch 'develop' into hm/unblock-request-snaps

6aa1120

hmalik88 added the team-snaps-platform Snaps Platform team label Aug 28, 2024

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 28, 2024

hmalik88 removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 28, 2024

hmalik88 marked this pull request as ready for review August 28, 2024 14:15

hmalik88 requested review from a team as code owners August 28, 2024 14:15

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 28, 2024

lint fix

65c870f

hmalik88 removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 28, 2024

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 28, 2024

another lint fix

8e9f0c5

hmalik88 added 2 commits August 28, 2024 11:39

update mockstate

75af6f1

Merge branch 'develop' into hm/unblock-request-snaps

99ffde8

FrederikBolding reviewed Aug 29, 2024

View reviewed changes

ui/pages/permissions-connect/snaps/snaps-connect/snaps-connect.js Outdated Show resolved Hide resolved

hmalik88 added 3 commits August 29, 2024 12:44

did some deduplication

7aef11b

Merge branch 'develop' into hm/unblock-request-snaps

61f40ef

lint fix

d7a517d

FrederikBolding reviewed Aug 30, 2024

View reviewed changes

ui/pages/permissions-connect/snaps/snaps-connect/snaps-connect.js Outdated Show resolved Hide resolved

hmalik88 added 2 commits August 30, 2024 10:24

use correct property

19e8182

Merge branch 'develop' into hm/unblock-request-snaps

e87b7fd

FrederikBolding previously approved these changes Aug 30, 2024

View reviewed changes

FrederikBolding reviewed Aug 30, 2024

View reviewed changes

ui/pages/snaps/snap-view/snap-settings.js Show resolved Hide resolved

FrederikBolding reviewed Aug 30, 2024

View reviewed changes

ui/pages/permissions-connect/snaps/snaps-connect/snaps-connect.js Outdated Show resolved Hide resolved

FrederikBolding reviewed Aug 30, 2024

View reviewed changes

ui/components/app/snaps/snap-metadata-modal/snap-metadata-modal.js Show resolved Hide resolved

Merge branch 'develop' into hm/unblock-request-snaps

c666963

hmalik88 changed the title ~~feat: unblock wallet_requestSnaps~~ fix: Show correct origins when snaps use wallet_requestSnaps Aug 30, 2024

pr suggestions

3ed97f6

hmalik88 dismissed FrederikBolding’s stale review via 3ed97f6 August 30, 2024 17:30

FrederikBolding approved these changes Sep 2, 2024

View reviewed changes

FrederikBolding reviewed Sep 2, 2024

View reviewed changes

ui/pages/permissions-connect/snaps/snaps-connect/snaps-connect.js Outdated Show resolved Hide resolved

FrederikBolding requested changes Sep 2, 2024

View reviewed changes

ui/pages/snaps/snap-view/snap-settings.js Show resolved Hide resolved

hmalik88 added 2 commits September 2, 2024 14:41

hack for selector throwing

736aebd

Merge branch 'develop' into hm/unblock-request-snaps

53f11f8

hmalik88 added 2 commits September 3, 2024 11:04

update connected sites list component for snaps

6dc0a37

Merge branch 'develop' into hm/unblock-request-snaps

3a8b268

fix

ba5453a

FrederikBolding mentioned this pull request Sep 5, 2024

feat: use new SnapAuthorshipPill component to show snap origin in confirmation flow #26881

Merged

7 tasks

FrederikBolding approved these changes Sep 5, 2024

View reviewed changes

david0xd approved these changes Sep 5, 2024

View reviewed changes

hmalik88 merged commit b5a7b5c into develop Sep 5, 2024
78 checks passed

hmalik88 deleted the hm/unblock-request-snaps branch September 5, 2024 13:34

github-actions bot locked and limited conversation to collaborators Sep 5, 2024

metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 5, 2024

gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Show correct origins when snaps use `wallet_requestSnaps` #26715

fix: Show correct origins when snaps use `wallet_requestSnaps` #26715

hmalik88 commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024

metamaskbot commented Aug 28, 2024

codecov bot commented Aug 28, 2024 •

edited

Loading

metamaskbot commented Aug 28, 2024

FrederikBolding left a comment

metamaskbot commented Sep 2, 2024

metamaskbot commented Sep 3, 2024

sonarcloud bot commented Sep 3, 2024

metamaskbot commented Sep 3, 2024

fix: Show correct origins when snaps use wallet_requestSnaps #26715

fix: Show correct origins when snaps use wallet_requestSnaps #26715

Conversation

hmalik88 commented Aug 28, 2024 • edited Loading

Description

Related issues

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Aug 28, 2024

metamaskbot commented Aug 28, 2024

codecov bot commented Aug 28, 2024 • edited Loading

Codecov Report

metamaskbot commented Aug 28, 2024

FrederikBolding left a comment

Choose a reason for hiding this comment

metamaskbot commented Sep 2, 2024

metamaskbot commented Sep 3, 2024

sonarcloud bot commented Sep 3, 2024

Quality Gate passed

metamaskbot commented Sep 3, 2024

fix: Show correct origins when snaps use `wallet_requestSnaps` #26715

fix: Show correct origins when snaps use `wallet_requestSnaps` #26715

hmalik88 commented Aug 28, 2024 •

edited

Loading

codecov bot commented Aug 28, 2024 •

edited

Loading