perf: ensure setupLocale doesn't fetch _locales/en/messages.json twice
#26553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
davidmurdoch
force-pushed
the
optimize-setuplocale
branch
from
3e3be88
to
76c903e
Compare
Builds ready [76c903e]
Page Load Metrics (87 ± 22 ms)
Bundle size diffs
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26553 +/- ##
===========================================
+ Coverage 69.96% 70.01% +0.05%
===========================================
Files 1405 1405
Lines 48996 49049 +53
Branches 13697 13714 +17
===========================================
+ Hits 34280 34341 +61
+ Misses 14716 14708 -8 ☔ View full report in Codecov by Sentry. |
davidmurdoch
force-pushed
the
optimize-setuplocale
branch
from
76c903e
to
ba6741c
Compare
|
davidmurdoch
commented
Aug 20, 2024
Comment on lines
+8
to
+28
| const enRelativeTime = loadRelativeTimeFormatLocaleData(defaultLocale); | ||
| const enLocale = fetchLocale(defaultLocale); | ||
|
|
||
| await loadRelativeTimeFormatLocaleData('en'); | ||
| if (currentLocale) { | ||
| await loadRelativeTimeFormatLocaleData(currentLocale); | ||
| const promises = [enRelativeTime, enLocale]; | ||
| if (currentLocale === defaultLocale) { | ||
| // enLocaleMessages and currentLocaleMessages are the same; reuse enLocale | ||
| promises.push(enLocale); // currentLocaleMessages | ||
| } else if (currentLocale) { | ||
| // currentLocale does not match enLocaleMessages | ||
| promises.push(fetchLocale(currentLocale)); // currentLocaleMessages | ||
| promises.push(loadRelativeTimeFormatLocaleData(currentLocale)); | ||
| } else { | ||
| // currentLocale is not set | ||
| promises.push(Promise.resolve({})); // currentLocaleMessages | ||
| } | ||
|
|
||
| const [, enLocaleMessages, currentLocaleMessages] = await Promise.all( | ||
| promises, | ||
| ); |
There was a problem hiding this comment.
This is really two changes:
- don't fetch the
"en"locale twice - if we have to fetch multiple locales, do them at the same time.
Builds ready [ba6741c]
Page Load Metrics (75 ± 6 ms)
Bundle size diffs
|
HowardBraham
added
the
team-tiger
Builds ready [5982850]
Page Load Metrics (1993 ± 128 ms)
Bundle size diffs
|
HowardBraham
force-pushed
the
optimize-setuplocale
branch
from
5982850
to
7602777
Compare
HowardBraham
force-pushed
the
optimize-setuplocale
branch
from
7602777
to
5a18b3a
Compare
|
HowardBraham
approved these changes
Oct 11, 2024
vthomas13
approved these changes
Oct 28, 2024
Builds ready [5a18b3a]
Page Load Metrics (2047 ± 57 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [b49a9a4]
Page Load Metrics (1931 ± 104 ms)
Bundle size diffs
|
DDDDDanica
approved these changes
Nov 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-12.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always load the english version of
messages.json, but we also always load the user's locale'smessages.json. These can be the same thing but our locale loader didn't take that into consideration. This PR updates the function to only load the user's local if it differs from our default locale, otherwise it just uses the samemessages.jsonbetween the two.Our locale function has a side effect: it loads locale-related Internationalization features as well. So this PR also updates those side-effects in a similar manner to avoid doing the work twice.