Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move middleware into its own directory, add Wallet-API-Platform team to CODEOWNERS #26549

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Aug 20, 2024

Description

  • Move dangling middleware currently living in app/scripts/lib into its own middleware subdirectory,
  • Add Wallet-API-Platform team to CODEOWNERS.md

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adonesky1 adonesky1 force-pushed the ad/wallet-api-platform-codeowners branch from 7dcbe95 to 33c7df6 Compare August 21, 2024 14:51
Copy link

sonarcloud bot commented Aug 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@adonesky1 adonesky1 changed the title Move middleware into its own directory, add Wallet-API-Platform team to CODEOWNERS chore: Move middleware into its own directory, add Wallet-API-Platform team to CODEOWNERS Aug 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [9e7c8b2]
Page Load Metrics (80 ± 18 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint692501083919
domContentLoaded48234764019
load55234803818
domInteractive9155323015
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 482 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.01%. Comparing base (084768a) to head (9e7c8b2).
Report is 755 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26549      +/-   ##
===========================================
+ Coverage    69.96%   70.01%   +0.05%     
===========================================
  Files         1405     1409       +4     
  Lines        49005    49115     +110     
  Branches     13703    13737      +34     
===========================================
+ Hits         34284    34386     +102     
- Misses       14721    14729       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adonesky1
Copy link
Contributor Author

adonesky1 commented Aug 21, 2024

Sonarcloud security issue is not introduced in this PR. Just activated in a file that's been moved. Just doesn't like use of math.random - used for sampling metrics. Can be safely ignored.

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale issues and PRs marked as stale team-wallet-api-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants