Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove submitRequest from dapp permission #26276

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Aug 1, 2024

Description

This pr updates the e2e testing for user operations to use the latest snap and removes the submitRequest permission from dapps.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/554

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [13d9291]
Page Load Metrics (237 ± 221 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint673831288340
domContentLoaded9181323919
load381678237461221
domInteractive9181323919
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -33 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@montelaidev montelaidev marked this pull request as ready for review August 1, 2024 13:25
@montelaidev montelaidev requested review from a team as code owners August 1, 2024 13:25
Copy link

sonarcloud bot commented Aug 1, 2024

@montelaidev montelaidev merged commit 3f09c80 into develop Aug 1, 2024
74 of 75 checks passed
@montelaidev montelaidev deleted the fix/ap-554 branch August 1, 2024 13:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 1, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [c23853c]
Page Load Metrics (432 ± 336 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint762061203617
domContentLoaded10128342713
load532061432699336
domInteractive10128332713
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -33 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants