Skip to content

Conversation

@mikesposito
Copy link
Member

@mikesposito mikesposito commented Jul 18, 2024

Description

This PR introduced a peerDependency warning due to unmatched @metamask/signature-controller peer dependency for @metamask/keyring-controller.

This PR updates @metamask/signature-controller to fix the warning, and @metamask/user-operation-controller as well since the new @metamask/signature-controller version would not match @metamask/user-operation-controller required version.

See changelogs for detailed differences between versions:

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mikesposito mikesposito requested a review from a team as a code owner July 18, 2024 12:31
@mikesposito
Copy link
Member Author

@metamaskbot update-policies

@socket-security
Copy link

socket-security bot commented Jul 18, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/signature-controller@18.0.0 None +6 1.16 MB metamaskbot
npm/@metamask/user-operation-controller@14.0.0 network +12 3.71 MB metamaskbot

🚮 Removed packages: npm/@metamask/signature-controller@16.0.0, npm/@metamask/user-operation-controller@10.0.0

View full report↗︎

@mikesposito mikesposito mentioned this pull request Jul 18, 2024
7 tasks
@mikesposito mikesposito requested a review from Gudahtt July 18, 2024 12:34
@mikesposito mikesposito added the team-accounts-framework Accounts Framework team label Jul 18, 2024
@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot metamaskbot requested review from a team as code owners July 18, 2024 12:47
@sonarqubecloud
Copy link

@mikesposito mikesposito marked this pull request as draft July 18, 2024 13:01
@mikesposito
Copy link
Member Author

Converting to draft since there are some missing methods from @metamask/signature-controller due to eth_sign being removed

@Gudahtt
Copy link
Member

Gudahtt commented Jul 18, 2024

Related: #24756

@mikesposito mikesposito deleted the chore/fix-deps-warning branch August 28, 2024 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants