Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Code cleanup on quoted attributes #25783

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix: Code cleanup on quoted attributes #25783

merged 1 commit into from
Sep 5, 2024

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Jul 11, 2024

Description

There are a number of places where we're using {'STRING'} where we don't need to. This PR cleans up those cases.

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. No feature/functional change

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested review from a team as code owners July 11, 2024 19:06
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Jul 11, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [284f7fa]
Page Load Metrics (156 ± 161 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint711501072110
domContentLoaded108333178
load431615156336161
domInteractive108333178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.96%. Comparing base (5ee57a6) to head (284f7fa).
Report is 39 commits behind head on develop.

Files Patch % Lines
...s/app/alert-system/general-alert/general-alert.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25783      +/-   ##
===========================================
+ Coverage    69.77%   69.96%   +0.19%     
===========================================
  Files         1376     1390      +14     
  Lines        48403    48895     +492     
  Branches     13348    13451     +103     
===========================================
+ Hits         33773    34207     +434     
- Misses       14630    14688      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkwing darkwing added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jul 12, 2024
@darkwing darkwing merged commit 8ffbb54 into develop Sep 5, 2024
80 of 81 checks passed
@darkwing darkwing deleted the quotes branch September 5, 2024 20:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 5, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants