cherry-pick – chore: bump transaction-controller to 29.0.2 (#24701) into v11.16.0 #24740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policy update failed. You can review the logs or retry the policy update here |
Bump transaction controller to get a couple fixes in. [](https://codespaces.new/MetaMask/metamask-extension/pull/24701?quickstart=1) Fixes: #24586 Fixes: #24183 Related: #24359 @keithchew to verify 1. Go to this page... 2. 3. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
danjm
force-pushed
the
Version-v11.16.0-txctlr-bump
branch
from
fb4023f to
6dbe537
Compare
dbrans
force-pushed
the
Version-v11.16.0-txctlr-bump
branch
from
6dbe537 to
6ece696
Compare
danjm
force-pushed
the
Version-v11.16.0-txctlr-bump
branch
from
6ece696 to
6dbe537
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v11.16.0 #24740 +/- ##
=================================================
Coverage 67.42% 67.42%
=================================================
Files 1265 1265
Lines 49385 49385
Branches 12846 12846
=================================================
Hits 33296 33296
Misses 16089 16089 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [6dbe537]
Page Load Metrics (1141 ± 576 ms)
|
metamaskbot
added
the
release-11.16.0
Collaborator
|
No release label on PR. Adding release label release-11.16.0 on PR, as PR was cherry-picked in branch 11.16.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
](https://codespaces.new/MetaMask/metamask-extension/pull/24701?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick – chore: bump transaction-controller to 29.0.2 637c0f3 (#24701) into v11.16.0
Notes: