fix(deps): update from eth-rpc-errors to @metamask/rpc-errors (cause edition) #24496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
legobeat
force-pushed
the
deps-eth-rpc-errors-testing2
branch
3 times, most recently
from
81de478 to
d2b1465
Compare
This comment was marked as resolved.
This comment was marked as resolved.
legobeat
force-pushed
the
deps-eth-rpc-errors-testing2
branch
4 times, most recently
from
1681c02 to
7dc9514
Compare
legobeat
changed the title
legobeat
force-pushed
the
deps-eth-rpc-errors-testing2
branch
18 times, most recently
from
2faf92d to
449fd01
Compare
FrederikBolding
previously approved these changes
Oct 11, 2024
FrederikBolding
approved these changes
Oct 11, 2024
legobeat
force-pushed
the
deps-eth-rpc-errors-testing2
branch
2 times, most recently
from
7afcd4e to
f2a2a9f
Compare
legobeat
force-pushed
the
deps-eth-rpc-errors-testing2
branch
from
f2a2a9f to
71f6a0a
Compare
mikesposito
approved these changes
Oct 15, 2024
legobeat
force-pushed
the
deps-eth-rpc-errors-testing2
branch
2 times, most recently
from
a6ef3a2 to
ca8cbcb
Compare
jpuri
approved these changes
Oct 16, 2024
darkwing
approved these changes
Oct 16, 2024
legobeat
force-pushed
the
deps-eth-rpc-errors-testing2
branch
from
ca8cbcb to
f48cf6f
Compare
fix error message handling fix: prefer cause message as error message lint:fix fix: update error handling for nft ownership check fix: handle error details in error cause fix test fixup cause handling Revert "fix test" This reverts commit e5ae79be58cf22b873ede78ac8edac08832bcaac. fix test fix: isErrorWithMessage return type Refactor: Handling error.cause; add pony-cause use getErrorMessage for logging errors WIP: deps: @metamask/rpc-errors@^6.2.1->6.3.0 test: fix testcase fix: consider cause instead of data.cause when parsing caught error messages chore: clean up unused cause-handling code in error.ts chore: update lavamoat policies revert stringification of generic objects in logErrorWithMessage lint:fix
MetaMask/rpc-errors#158 - Update test according to new @metamask/rpc-errors behavior This partially reverts commit aeca6d797fc16d13bcd16f8649159769207ede78.
Gudahtt
force-pushed
the
deps-eth-rpc-errors-testing2
branch
from
f48cf6f to
2733a31
Compare
Member
|
Force-merged to override |
gauthierpetetin
added
release-12.7.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
eth-rpc-errorsto@metamask/rpc-errorsSee here for some context.
Related issues
eth-rpc-errorsto@metamask/rpc-errors#22871Blocked by
Blocking
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist