chore: Revert "fix: needs to be always true for MMI (#24163)"

[legobeat]

Description

#24163 seems to have been introduced a regression resulting in failing MMI-related jobs.

#24163 (comment)

This reverts it.

Related issues

• fix: needs to be always true for MMI #24163

Manual testing steps

n/a

Screenshots/Recordings

Before

n/a

After

n/a

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.47%. Comparing base (b3c8d32) to head (d53f4e2).

Files	Patch %	Lines
app/scripts/lib/setupSentry.js	0.00%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #24185   +/-   ##
========================================
  Coverage    67.47%   67.47%           
========================================
  Files         1257     1257           
  Lines        49232    49232           
  Branches     12822    12823    +1     
========================================
  Hits         33216    33216           
  Misses       16016    16016           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [d53f4e2]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (306 ± 347 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	119	83	17	8
		domContentLoaded	9	57	20	14	7
		load	49	2598	306	722	347
		domInteractive	9	57	20	14	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 93 Bytes (0.00%)

[zone-live]

I don't think this needs to be reverted. Develop has not had any fail in CI because of this, and at the time this PR was merged, the pipeline was up to data with develop and green.

Last two runs in develop:
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/77524/workflows/2b0e96b2-bb3e-49ce-b1ed-cf944fb6a7d1
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/77515/workflows/d9a86e46-b934-42d5-8fd3-d9f2fcf3ddfc

cc @legobeat

[zone-live]

The cause for the fails you mention in this PR might be because its not up to date with develop. I'll check 👍🏼

by the time this one was merged, all was green: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/77481/workflows/528e4a54-b5e3-463a-9373-b12b078e6fb7
Also other PRs open right now against develop don't have any issue with our build

[legobeat]

The cause for the fails you mention in this PR might be because its not up to date with develop. I'll check 👍🏼

by the time this one was merged, all was green: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/77481/workflows/528e4a54-b5e3-463a-9373-b12b078e6fb7 Also other PRs open right now against develop don't have any issue with our build

Example failure; up to date with develop: #23216

[zone-live]

The cause for the fails you mention in this PR might be because its not up to date with develop. I'll check 👍🏼
by the time this one was merged, all was green: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/77481/workflows/528e4a54-b5e3-463a-9373-b12b078e6fb7 Also other PRs open right now against develop don't have any issue with our build

Example failure; up to date with develop: #23216

This is happening only to forked repos, how can we make sure they have the last develop up to date? why is it not happening in PRs from the main codebase?
Also if this PR gets reverted it will add back unnecessary code. It's preferable if I just create a PR do add back the variable to builds.yml.

@legobeat it says that the variable is declared in the builds.yml, but CircleCI can't get its value from environment variables. But its there.

A new PR that adds back the variable: #24190

[zone-live]

for visibility here as well: #24192
cc @legobeat

[legobeat]

Superseded by #24192

See also:

• chore(ci): fix check-pr-tag job #24193