Skip to content

Conversation

@micaelae
Copy link
Member

@micaelae micaelae commented Apr 11, 2024

Description

This fixes the style of footer buttons in the new-network component so they are readable in both light and dark mode.

Open in GitHub Codespaces

Related issues

Fixes: 23725

Manual testing steps

  1. Turn on dark mode setting in extension
  2. Add a new network
  3. Verify that "Got it" button text is black
  4. Verify that "Learn to bridge" button text is blue
  5. Verify that "Learn to bridge" button text is black on hover
  6. Turn on light mode setting in extension
  7. Add a new network
  8. Verify that "Got it" button text is white
  9. Verify that "Learn to bridge" button text is blue
  10. Verify that "Learn to bridge" button text is white on hover

Screenshots/Recordings

Before

image

After

Screenshot 2024-04-11 at 10 59 23 AM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead team-bridge-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead release-11.14.0 Issue or pull request that will be included in release 11.14.0 labels Apr 11, 2024
@micaelae micaelae requested a review from a team as a code owner April 11, 2024 19:28
@hjetpoluru hjetpoluru self-requested a review April 11, 2024 20:18
@micaelae micaelae force-pushed the mb-new-network-button-color branch 2 times, most recently from b531f05 to 6dc5cde Compare April 12, 2024 17:41
@metamaskbot
Copy link
Collaborator

Builds ready [6dc5cde]
Page Load Metrics (648 ± 471 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint671721022211
domContentLoaded116529157
load542533648980471
domInteractive116529157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -8 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.56%. Comparing base (d6987bb) to head (d25e73e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23988   +/-   ##
========================================
  Coverage    67.56%   67.56%           
========================================
  Files         1246     1246           
  Lines        48888    48888           
  Branches     12746    12746           
========================================
  Hits         33031    33031           
  Misses       15857    15857           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@micaelae micaelae force-pushed the mb-new-network-button-color branch from 6dc5cde to 8bd8e77 Compare April 12, 2024 19:28
@metamaskbot
Copy link
Collaborator

Builds ready [8bd8e77]
Page Load Metrics (675 ± 494 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint744481277938
domContentLoaded107729199
load6626806751030494
domInteractive107729199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -8 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae force-pushed the mb-new-network-button-color branch from 8bd8e77 to d25e73e Compare April 12, 2024 20:07
@metamaskbot
Copy link
Collaborator

Builds ready [d25e73e]
Page Load Metrics (1012 ± 549 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint601981274722
domContentLoaded96427147
load48256310121144549
domInteractive96427147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -8 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae merged commit 25ae5a4 into develop Apr 12, 2024
@micaelae micaelae deleted the mb-new-network-button-color branch April 12, 2024 20:35
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 12, 2024
@seaona
Copy link
Member

seaona commented Apr 15, 2024

thank you @micaelae , I see the issue fixed now 🔥

Screenshot from 2024-04-15 09-26-14

Screenshot from 2024-04-15 09-26-45

@metamaskbot metamaskbot removed the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 23, 2024
@metamaskbot
Copy link
Collaborator

More than one release label on PR. Keeping the lowest one (release-11.14.0) on PR and removing other release labels (release-11.16.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-bridge-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Bug]: Got it button style seems incorrect: letters were white now are black, degrading readability

8 participants