-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix: new-network button label colors are not readable in light mode #23988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BZahory
approved these changes
Apr 11, 2024
ejwessel
approved these changes
Apr 11, 2024
hjetpoluru
approved these changes
Apr 11, 2024
b531f05 to
6dc5cde
Compare
Collaborator
Builds ready [6dc5cde]
Page Load Metrics (648 ± 471 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23988 +/- ##
========================================
Coverage 67.56% 67.56%
========================================
Files 1246 1246
Lines 48888 48888
Branches 12746 12746
========================================
Hits 33031 33031
Misses 15857 15857 ☔ View full report in Codecov by Sentry. |
6dc5cde to
8bd8e77
Compare
georgeweiler
approved these changes
Apr 12, 2024
Collaborator
Builds ready [8bd8e77]
Page Load Metrics (675 ± 494 ms)
Bundle size diffs
|
8bd8e77 to
d25e73e
Compare
Collaborator
Builds ready [d25e73e]
Page Load Metrics (1012 ± 549 ms)
Bundle size diffs
|
Member
|
thank you @micaelae , I see the issue fixed now 🔥 |
Collaborator
|
More than one release label on PR. Keeping the lowest one (release-11.14.0) on PR and removing other release labels (release-11.16.0). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
regression-RC
DEPRECATED: Please use "regresssion-RC-x.y.z" label instead
release-11.14.0
Issue or pull request that will be included in release 11.14.0
team-bridge-deprecated
DEPRECATED: please use "team-swaps-and-bridge" instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Description
This fixes the style of footer buttons in the new-network component so they are readable in both light and dark mode.
Related issues
Fixes: 23725
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist