fix: improve performance in account list and account connection components

[FrederikBolding]

Description

Improves performance in the account list and "account connection" components by no longer leveraging getAddressConnectedSubjectMap. The selector in question is very computationally expensive to use and thus were causing performance problems for users with many accounts and many connected sites. This PR proposes using getPermittedAccountsForCurrentTab where possible and also introduces a memoized selector isAccountConnectedToCurrentTab that performantly can check for a given address.

From local testing this seems to improve the experience.

Related issues

Fixes #23913

[codecov]

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 67.52%. Comparing base (d15cc54) to head (a6e4dfc).
Report is 60 commits behind head on develop.

Files	Patch %	Lines
...ted-status-indicator/connected-status-indicator.js	0.00%	4 Missing ⚠️
...s/multichain/connected-status/connected-status.tsx	0.00%	2 Missing ⚠️
ui/selectors/permissions.js	80.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #23933      +/-   ##
===========================================
- Coverage    67.54%   67.52%   -0.02%     
===========================================
  Files         1245     1245              
  Lines        48864    48869       +5     
  Branches     12744    12742       -2     
===========================================
- Hits         33003    32995       -8     
- Misses       15861    15874      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [e80f64e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1550 ± 513 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	74	361	161	85	41
		domContentLoaded	10	91	30	20	10
		load	60	2671	1550	1068	513
		domInteractive	10	91	30	20	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: -236 Bytes (-0.00%)
• common: 145 Bytes (0.00%)

[metamaskbot]

Builds ready [a6e4dfc]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1465 ± 542 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	63	557	178	118	57
		domContentLoaded	10	50	26	12	6
		load	51	2759	1465	1129	542
		domInteractive	10	50	26	12	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: -236 Bytes (-0.00%)
• common: 145 Bytes (0.00%)

[NidhiKJha]

LGTM! Verified locally, everything works