refactor: Typescript conversion of log-web3-shim-usage.js #23732

NiranjanaBinoy · 2024-03-26T15:32:05Z

Converting the level 6 dependency file app/scripts/lib/rpc-method-middleware/handlers/log-web3-shim-usage.js to typescript for contributing to metamask-controller.js.

Description

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-03-26T15:32:18Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-04-09T16:12:10Z

Builds ready [975bbe0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1026 ± 503 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	76	226	113	39	19
		domContentLoaded	10	71	26	18	9
		load	62	2426	1026	1047	503
		domInteractive	10	71	26	18	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

github-actions · 2024-06-08T20:04:16Z

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

github-actions · 2024-06-22T20:04:35Z

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

codecov · 2024-06-25T15:36:26Z

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.14%. Comparing base (ce04ae8) to head (9000e66).

Files with missing lines	Patch %	Lines
...-method-middleware/handlers/log-web3-shim-usage.ts	14.29%	6 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #23732   +/-   ##
========================================
  Coverage    70.14%   70.14%           
========================================
  Files         1424     1424           
  Lines        49572    49572           
  Branches     13868    13868           
========================================
  Hits         34769    34769           
  Misses       14803    14803

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-06-25T15:49:14Z

Builds ready [aac4215]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (57 ± 7 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	123	91	11	5
		domContentLoaded	10	26	13	4	2
		load	44	94	57	14	7
		domInteractive	10	26	13	4	2

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

sonarcloud · 2024-07-18T20:14:44Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-18T21:07:43Z

Builds ready [cb7ad5d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (308 ± 272 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	121	100	15	7
		domContentLoaded	9	50	27	10	5
		load	47	1854	308	566	272
		domInteractive	9	50	27	10	5

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

sonarcloud · 2024-09-03T21:27:36Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-03T21:56:29Z

Builds ready [9000e66]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1824 ± 97 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	237	2188	1447	664	319
		domContentLoaded	1513	2244	1808	200	96
		load	1521	2247	1824	202	97
		domInteractive	15	69	39	16	8

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

sonarcloud · 2024-10-08T03:57:16Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-10-08T04:16:46Z

Builds ready [8445652]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1694 ± 100 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1498	2275	1692	209	100
		domContentLoaded	1490	2227	1668	198	95
		load	1498	2276	1694	207	100
		domInteractive	16	88	40	19	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

NiranjanaBinoy added the team-extension-platform label Mar 26, 2024

NiranjanaBinoy self-assigned this Mar 26, 2024

NiranjanaBinoy changed the base branch from develop to extract-wrapper-type March 27, 2024 20:16

NiranjanaBinoy changed the base branch from extract-wrapper-type to develop March 27, 2024 20:16

NiranjanaBinoy force-pushed the ts-log-web3-shim-usage branch from c063564 to f1e8bd0 Compare March 27, 2024 20:25

NiranjanaBinoy changed the base branch from develop to extract-wrapper-type March 27, 2024 20:27

metamaskbot added the in-progress label Mar 28, 2024

NiranjanaBinoy force-pushed the ts-log-web3-shim-usage branch from 0a09193 to 4afeae1 Compare March 28, 2024 16:20

NiranjanaBinoy force-pushed the ts-log-web3-shim-usage branch from e89505c to fca464b Compare April 9, 2024 18:38

github-actions bot added the stale issues and PRs marked as stale label Jun 8, 2024

github-actions bot closed this Jun 22, 2024

NiranjanaBinoy reopened this Jun 25, 2024

NiranjanaBinoy changed the base branch from extract-wrapper-type to develop June 25, 2024 15:13

github-actions bot removed the stale issues and PRs marked as stale label Jun 25, 2024

NiranjanaBinoy force-pushed the ts-log-web3-shim-usage branch from c93945b to cb7ad5d Compare July 18, 2024 20:12

NiranjanaBinoy marked this pull request as ready for review July 18, 2024 21:25

NiranjanaBinoy requested a review from a team as a code owner July 18, 2024 21:25

MajorLift mentioned this pull request Aug 20, 2024

chore(deps): Bump @metamask/utils from ^8.2.1 to ^9.1.0 #26551

Merged

8 tasks

NiranjanaBinoy removed the in-progress label Sep 3, 2024

NiranjanaBinoy force-pushed the ts-log-web3-shim-usage branch from 855fab5 to 9000e66 Compare September 3, 2024 21:25

NiranjanaBinoy added 16 commits October 4, 2024 16:55

updating with a helper file

0069555

updating the naming case

2faf56d

remaining the types and rearranging the order

9cada60

updating jsdoc

200c1d8

typescript conversion of teh file and type definition in handler

27d04bd

removing the old file after rebasing with extract-wrapper-type

7d1ee94

updating to pendingjsonrpcresponse

b11e711

adding the types needed for add-ethereum-chain

4650dc8

adding the types needed for request_accounts file

f04fdf0

adding the types for switch-ethereum-chain

88f4dc4

adding the return type

00ff901

updating HandlerWrapper.methodNames type

08fe9a2

updating the types file

f53ab1a

updating the requesttype

0f8e671

adding unit test

8452666

updating OriginString to string type

4737ce1

NiranjanaBinoy force-pushed the ts-log-web3-shim-usage branch 2 times, most recently from 4737ce1 to 6997d6d Compare October 8, 2024 03:09

updating dep

8445652

NiranjanaBinoy force-pushed the ts-log-web3-shim-usage branch from 6997d6d to 8445652 Compare October 8, 2024 03:45

DDDDDanica approved these changes Oct 8, 2024

View reviewed changes

MajorLift approved these changes Oct 8, 2024

View reviewed changes

NiranjanaBinoy added this pull request to the merge queue Oct 8, 2024

Merged via the queue into develop with commit 29bc2f5 Oct 8, 2024
78 checks passed

NiranjanaBinoy deleted the ts-log-web3-shim-usage branch October 8, 2024 17:01

github-actions bot locked and limited conversation to collaborators Oct 8, 2024

metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Typescript conversion of log-web3-shim-usage.js #23732

refactor: Typescript conversion of log-web3-shim-usage.js #23732

NiranjanaBinoy commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024

metamaskbot commented Apr 9, 2024

github-actions bot commented Jun 8, 2024

github-actions bot commented Jun 22, 2024

codecov bot commented Jun 25, 2024 •

edited

Loading

metamaskbot commented Jun 25, 2024

sonarcloud bot commented Jul 18, 2024

metamaskbot commented Jul 18, 2024

sonarcloud bot commented Sep 3, 2024

metamaskbot commented Sep 3, 2024

sonarcloud bot commented Oct 8, 2024

metamaskbot commented Oct 8, 2024

refactor: Typescript conversion of log-web3-shim-usage.js #23732

refactor: Typescript conversion of log-web3-shim-usage.js #23732

Conversation

NiranjanaBinoy commented Mar 26, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 26, 2024

metamaskbot commented Apr 9, 2024

github-actions bot commented Jun 8, 2024

github-actions bot commented Jun 22, 2024

codecov bot commented Jun 25, 2024 • edited Loading

Codecov Report

metamaskbot commented Jun 25, 2024

sonarcloud bot commented Jul 18, 2024

Quality Gate passed

metamaskbot commented Jul 18, 2024

sonarcloud bot commented Sep 3, 2024

Quality Gate passed

metamaskbot commented Sep 3, 2024

sonarcloud bot commented Oct 8, 2024

Quality Gate passed

metamaskbot commented Oct 8, 2024

NiranjanaBinoy commented Mar 26, 2024 •

edited

Loading

codecov bot commented Jun 25, 2024 •

edited

Loading