Skip to content

Conversation

@zone-live
Copy link
Contributor

@zone-live zone-live commented Mar 8, 2024

Description

Updates an e2e snapshot for MMI.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the mmi DEPRECATED: The product got sunset label Mar 8, 2024
@zone-live zone-live requested review from a team, brad-decker and kumavis as code owners March 8, 2024 14:07
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.72%. Comparing base (62a21bc) to head (6665bbf).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23395   +/-   ##
========================================
  Coverage    68.72%   68.72%           
========================================
  Files         1122     1122           
  Lines        43577    43577           
  Branches     11661    11661           
========================================
  Hits         29945    29945           
  Misses       13632    13632           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [d347573]
Page Load Metrics (1311 ± 485 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint822861404522
domContentLoaded12131443115
load69300213111010485
domInteractive11131443115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

brad-decker
brad-decker previously approved these changes Mar 11, 2024
albertolive
albertolive previously approved these changes Mar 12, 2024
@zone-live zone-live dismissed stale reviews from brad-decker and albertolive via 6665bbf March 12, 2024 11:02
@zone-live zone-live requested a review from albertolive March 12, 2024 11:14
@metamaskbot
Copy link
Collaborator

Builds ready [6665bbf]
Page Load Metrics (1062 ± 386 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint692161274120
domContentLoaded10105312813
load5718941062805386
domInteractive10105312813
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live requested a review from brad-decker March 12, 2024 12:15
@zone-live zone-live merged commit 1803b49 into develop Mar 12, 2024
@zone-live zone-live deleted the MMI-fix-e2e-snapshot branch March 12, 2024 13:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

mmi DEPRECATED: The product got sunset release-11.14.0 Issue or pull request that will be included in release 11.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants