-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: reveal and hide private keys #23371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [43cd92e]
Page Load Metrics (747 ± 394 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23371 +/- ##
===========================================
- Coverage 68.66% 68.66% -0.00%
===========================================
Files 1105 1105
Lines 43330 43333 +3
Branches 11581 11582 +1
===========================================
+ Hits 29749 29751 +2
- Misses 13581 13582 +1 ☔ View full report in Codecov by Sentry. |
Description
Adds a show/hide element which toggles whether the private key input value is visible or not.
Note
This is the same PR as #20719 from external repo, due to
ci/circleci: prep-depsalways failed for external contributor. I create this PR internally as workaround to run CI.Related issues
Fixes: #20630
Manual testing steps
Import accountScreenshots/Recordings
Before
before1080.mov
After
after1080.mov
Pre-merge author checklist
Pre-merge reviewer checklist