-
Notifications
You must be signed in to change notification settings - Fork 5.4k
docs: [E2E] Update readme for e2e tests #23309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [ec8ed70]
Page Load Metrics (808 ± 463 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23309 +/- ##
========================================
Coverage 68.59% 68.59%
========================================
Files 1101 1101
Lines 43176 43176
Branches 11552 11552
========================================
Hits 29615 29615
Misses 13561 13561 ☔ View full report in Codecov by Sentry. |
Builds ready [7f367a3]
Page Load Metrics (1066 ± 435 ms)
Bundle size diffs
|
Builds ready [6ec8bc8]
Page Load Metrics (888 ± 426 ms)
Bundle size diffs
|
|
Overall looks good 😻 Left a small suggestion |
Builds ready [3f6d197]
Page Load Metrics (1151 ± 376 ms)
Bundle size diffs
|
darkwing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for improving documentation!
Description
This PR updates the E2E testing instructions in our README to enhance clarity and usability. The updates focus on:
yarn download-builds:testto download pre-built test builds.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2187
Manual testing steps
Try to follow readme to run e2e tests to see if it's clear.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist