Skip to content

Conversation

@benjisclowder
Copy link
Contributor

@benjisclowder benjisclowder commented Feb 28, 2024

Description

Removing Brian Bergeron from Accounts team and adding Chloe Gao to Extension Platform.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@benjisclowder benjisclowder added the team-extension-platform Extension Platform team label Feb 28, 2024
@benjisclowder benjisclowder requested review from a team and kumavis as code owners February 28, 2024 20:56
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [e082c1a]
Page Load Metrics (1218 ± 500 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint692761325727
domContentLoaded1086352512
load55247812181042500
domInteractive1086352512
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks Marina.

@metamaskbot
Copy link
Collaborator

Builds ready [4e4b002]
Page Load Metrics (1026 ± 410 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint781751173014
domContentLoaded105822136
load5219411026854410
domInteractive105822136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@benjisclowder benjisclowder merged commit 28fa64a into develop Mar 7, 2024
@benjisclowder benjisclowder deleted the Small-change-to-RC-commits-script branch March 7, 2024 12:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants