test: [Snaps E2E] Create test for Signature Insights #23133

bowensanders · 2024-02-22T20:41:04Z

Description

This creates a test for Signature Insights via snaps.

Related issues

Fixes: #22785

Manual testing steps

Run E2E test locally

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-02-22T20:41:18Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-02-22T23:04:16Z

Builds ready [0d66533]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1794 ± 70 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	116	476	231	113	54
		domContentLoaded	10	76	30	20	10
		load	1466	2114	1794	145	70
		domInteractive	10	76	30	20	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

hmalik88

🫡

test/e2e/snaps/test-snap-siginsights.spec.js

Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>

metamaskbot · 2024-02-26T23:11:47Z

Builds ready [960a2f9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1799 ± 32 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	111	283	175	44	21
		domContentLoaded	9	86	42	23	11
		load	1632	1939	1799	66	32
		domInteractive	9	85	42	23	11

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-02-28T21:09:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.63%. Comparing base (3134b86) to head (dd5cc86).
Report is 5 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #23133   +/-   ##
========================================
  Coverage    68.63%   68.63%           
========================================
  Files         1102     1102           
  Lines        43218    43218           
  Branches     11554    11554           
========================================
  Hits         29659    29659           
  Misses       13559    13559

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-02-28T21:14:40Z

Builds ready [6030f76]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1354 ± 465 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	278	133	56	27
		domContentLoaded	10	114	31	28	13
		load	58	2889	1354	969	465
		domInteractive	10	114	31	28	13

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-03-05T20:50:04Z

Builds ready [dd5cc86]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1020 ± 412 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	78	211	129	40	19
		domContentLoaded	11	72	27	16	8
		load	63	2047	1020	858	412
		domInteractive	11	72	27	16	8

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

added test

3fb6033

bowensanders self-assigned this Feb 22, 2024

bowensanders added area-snaps team-snaps-deprecated DEPRECATED: please use "team-core-platform" instead labels Feb 22, 2024

bowensanders changed the title ~~[Snaps E2E] Create test for Signature Insights~~ test: [Snaps E2E] Create test for Signature Insights Feb 22, 2024

bowensanders added 4 commits February 22, 2024 13:22

fixed enums and added testid

795d291

changed to local test-dapp

3bb73b0

made test flask only

2c2c5eb

removed comment

0d66533

FrederikBolding previously approved these changes Feb 26, 2024

View reviewed changes

bowensanders requested a review from hmalik88 February 26, 2024 20:53

bowensanders marked this pull request as ready for review February 26, 2024 22:42

bowensanders requested review from a team as code owners February 26, 2024 22:42

hmalik88 previously approved these changes Feb 26, 2024

View reviewed changes

test/e2e/snaps/test-snap-siginsights.spec.js Outdated Show resolved Hide resolved

Update test-snap-siginsights.spec.js

960a2f9

Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>

bowensanders dismissed stale reviews from hmalik88 and FrederikBolding via 960a2f9 February 26, 2024 22:50

bowensanders added 2 commits February 28, 2024 13:21

Merge branch 'develop' into bowen/signinsights2

306290e

fixed address

6030f76

bowensanders requested review from FrederikBolding and hmalik88 February 28, 2024 21:11

FrederikBolding approved these changes Feb 29, 2024

View reviewed changes

Merge branch 'develop' into bowen/signinsights2

dd5cc86

ziedbrini added team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) and removed team-snaps-deprecated DEPRECATED: please use "team-core-platform" instead labels Mar 6, 2024

Mrtenz approved these changes Mar 7, 2024

View reviewed changes

FrederikBolding merged commit be87264 into develop Mar 7, 2024

FrederikBolding deleted the bowen/signinsights2 branch March 7, 2024 09:24

github-actions bot locked and limited conversation to collaborators Mar 7, 2024

metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Mar 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: [Snaps E2E] Create test for Signature Insights #23133

test: [Snaps E2E] Create test for Signature Insights #23133

Uh oh!

bowensanders commented Feb 22, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Feb 22, 2024

Uh oh!

metamaskbot commented Feb 22, 2024

Uh oh!

hmalik88 left a comment

Uh oh!

Uh oh!

metamaskbot commented Feb 26, 2024

Uh oh!

codecov bot commented Feb 28, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Feb 28, 2024

Uh oh!

metamaskbot commented Mar 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

test: [Snaps E2E] Create test for Signature Insights #23133

test: [Snaps E2E] Create test for Signature Insights #23133

Uh oh!

Conversation

bowensanders commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Feb 22, 2024

Uh oh!

metamaskbot commented Feb 22, 2024

Uh oh!

hmalik88 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbot commented Feb 26, 2024

Uh oh!

codecov bot commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Feb 28, 2024

Uh oh!

metamaskbot commented Mar 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bowensanders commented Feb 22, 2024 •

edited

Loading

codecov bot commented Feb 28, 2024 •

edited

Loading