Cherry-pick 167036f (#22856) into v11.10.0

[danjm]

fix: fix selectedAddress and nftController instantiation (#22856)

Noticed that when you freshly import the extension, usse testDapp to deploy and mint an NFT, then manually import the NFT. you will be able to see the NFT. Then when you switch to another account and go back to the account that has the NFT;
1- you wont be able to see the NFTs you imported earlier 2- When you try to import them again you will get an error (fired from core when trying to verify ownership)

Noticed that this was due to core having the wrong userAddress to check ownership for, and then in metamask.js, the selectedAddress retrieved does not match the user's selected Address

This behavior is also reported to be on v11.10.0, on this issue: #22796

Fixes: #22796
Fixes: #22798

1. Remove and reimport the extension
2. Use testDapp to deploy and mint the NFT
3. Add the NFT manually by clicking "import NFT"
4. You should be able to see your newly import NFT
5. Create new account
6. Go back to the account that has the NFT
7. You should be able to see the NFT you imported

devBefore.mov

DevAfter.mov

• I’ve followed MetaMask Coding Standards.

• I've clearly explained what problem this PR is solving and how it is solved.

• I've linked related issues

• I've included manual testing steps

• I've included screenshots/recordings if applicable

• I’ve included tests if applicable

• I’ve documented my code using JSDoc format if applicable

• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

• I’ve properly set the pull request status:

  • In case it's not yet "ready for review", I've set it to "draft".

• In case it's "ready for review", I've changed it from "draft" to "non-draft".

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).

• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Description

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[danjm]

I QA'd and confirmed that the bugs this commit fixed are still fixed on this cherry-pick

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c2d8a9b) 68.03% compared to head (ef0deaf) 68.03%.

Files	Patch %	Lines
app/scripts/metamask-controller.js	50.00%	4 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                  @@
##           Version-v11.10.0   #23023      +/-   ##
====================================================
- Coverage             68.03%   68.03%   -0.01%     
====================================================
  Files                  1087     1087              
  Lines                 42892    42910      +18     
  Branches              11406    11411       +5     
====================================================
+ Hits                  29181    29190       +9     
- Misses                13711    13720       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [ef0deaf]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (796 ± 22 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	89	154	112	16	8
		domContentLoaded	9	50	18	9	4
		load	748	945	796	47	22
		domInteractive	9	50	18	9	4