-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: Remove unnecessary resolution for socks #22960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 5f5e935.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
@sahar-fehri are you sure that v2.8.0 is correct? It looks like latest is still v2.7.3 |
Builds ready [c32f85f]
Page Load Metrics (1132 ± 54 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22960 +/- ##
========================================
Coverage 68.54% 68.54%
========================================
Files 1088 1088
Lines 42904 42904
Branches 11413 11413
========================================
Hits 29408 29408
Misses 13496 13496 ☔ View full report in Codecov by Sentry. |
Gudahtt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
I've updated the PR title and description to explain the change better as well; feel free to edit further, just my suggestions. |
|
Missing release label release-11.11.0 on PR. Adding release label release-11.11.0 on PR and removing other release labels(release-11.12.0), as PR was cherry-picked in branch 11.11.0. |
Description
Remove unnecessary resolution for the
sockspackage. This removes the risk of the resolution causing problems in future updates, reducing maintenance burdens for the team.Related issues
N/A
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist