Skip to content

Conversation

@hjetpoluru
Copy link
Contributor

@hjetpoluru hjetpoluru commented Feb 14, 2024

New test written for the update network fails in the develop branch and hence needs to be reverted.

Reverts #22762

@hjetpoluru hjetpoluru requested a review from a team as a code owner February 14, 2024 15:07
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 14, 2024
@hjetpoluru hjetpoluru self-assigned this Feb 14, 2024
@hjetpoluru hjetpoluru added the team-extension-platform Extension Platform team label Feb 14, 2024
@codecov
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8b59c7) 68.54% compared to head (111427a) 68.54%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22946   +/-   ##
========================================
  Coverage    68.54%   68.54%           
========================================
  Files         1088     1088           
  Lines        42904    42904           
  Branches     11413    11413           
========================================
  Hits         29408    29408           
  Misses       13496    13496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjetpoluru hjetpoluru merged commit 12a0770 into develop Feb 14, 2024
@hjetpoluru hjetpoluru deleted the revert-22762-22542-add-e2e-test-for-update-network branch February 14, 2024 16:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 14, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [111427a]
Page Load Metrics (1027 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1122801854321
domContentLoaded968322311
load9061559102715574
domInteractive968322311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -153 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [111427a]
Page Load Metrics (1027 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1122801854321
domContentLoaded968322311
load9061559102715574
domInteractive968322311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -153 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants