Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace DetectTokensController with core monorepo's TokenDetectionController #22928

Merged
merged 42 commits into from
Mar 14, 2024
Merged

refactor: Replace DetectTokensController with core monorepo's TokenDetectionController #22928

merged 42 commits into from
Mar 14, 2024

Commits on Mar 9, 2024

  1. Remove detect-tokens.js and test file

    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    48d93c0 View commit details
    Browse the repository at this point in the history

  2. Bump @metamask/assets-controllers to v26, and peerDeps `@metamask/a… 

    …ccounts-controller`, `@metamask/keyring-controller`
    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    f8ba2f5 View commit details
    Browse the repository at this point in the history

  3. Update all references to DetectTokensController and `detectNewToken… 

    …s` into `TokenDetectionController` and `detectTokens`
    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    17db540 View commit details
    Browse the repository at this point in the history

  4. Remove all references to removed `detect-tokens.{,test.}js

    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    22c39c1 View commit details
    Browse the repository at this point in the history

  5. Reapply patches to new accounts-controller, keyring-controller versions

    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    fde07ec View commit details
    Browse the repository at this point in the history

  6. Remove packages unused in develop branch

    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    d7fe975 View commit details
    Browse the repository at this point in the history

  7. Add PreferencesController:stateChange to tokens-controller allowlist

    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    70d9d70 View commit details
    Browse the repository at this point in the history

  8. dedupe lockfile

    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    06d94f5 View commit details
    Browse the repository at this point in the history

  9. Update allowlist entries for tokens-controller, token-detection-contr… 

    …oller
    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    e36814b View commit details
    Browse the repository at this point in the history

  10. Remove unused constructor options in token-detection-controller insta… 

    …ntiation
    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    b507e95 View commit details
    Browse the repository at this point in the history

  11. Add preferences-controller getState action handler, stateChange subsc… 

    …ription
    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    8048e03 View commit details
    Browse the repository at this point in the history

  12. Update accounts-controller patch to fix failing unit tests

    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    a2fe4ce View commit details
    Browse the repository at this point in the history

  13. Add API callback for getNetworkClientById action

    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    66c6e9d View commit details
    Browse the repository at this point in the history

  14. test: Fix unit test to use messenger pattern for `getNetworkClientByI… 

    …d` action
    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    052b51b View commit details
    Browse the repository at this point in the history

  15. Remove unused dep @metamask/polling-controller

    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    f655b27 View commit details
    Browse the repository at this point in the history

  16. Apply lavamoat policies with diffs from check-working-tree script

    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    0c6854f View commit details
    Browse the repository at this point in the history

  17. Bump @metamask/keyring-controller to ^13.0.0 and reapply patch

    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    466a60c View commit details
    Browse the repository at this point in the history

  18. Bump @metamask/controller-utils to ^8.0.4

    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    144f436 View commit details
    Browse the repository at this point in the history

  19. test: fix keyringController.getAccounts call count

    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    500a539 View commit details
    Browse the repository at this point in the history

  20. Replace all imports of toChecksumHexAddress from `@metamask/control… 

    …ler-utils` with imports from `shared/modules/hexstring-utils`

- This is unrelated to the `@metamask/controller-utils` bump to `^8.0.4`. It's still necessary with `^8.0.1`.
    @MajorLift
    MajorLift committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    46827f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. Register action handler for TokensController:getState to `MetamaskC… 

    …ontroller` class controller-messenger
    @MajorLift
    MajorLift committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    12cf087 View commit details
    Browse the repository at this point in the history

  2. Refactor isClientOpen setter to call enable, disable on `tokenD… 

    …etectionController`
    @MajorLift
    MajorLift committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    ed9859d View commit details
    Browse the repository at this point in the history

  3. Add empty state object as entry for TokenDetectionController in `SE… 

    …NTRY_BACKGROUND_STATE` object
    @MajorLift
    MajorLift committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    a1a20ed View commit details
    Browse the repository at this point in the history

  4. test: Decrement numberOfMetaswapRequests

    @MajorLift
    MajorLift committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    08dd6b0 View commit details
    Browse the repository at this point in the history

  5. Remove unused patches

    @MajorLift
    MajorLift committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    0023df2 View commit details
    Browse the repository at this point in the history

  6. Edit @metamask/accounts-controller patch

    @MajorLift
    MajorLift committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    21c8d29 View commit details
    Browse the repository at this point in the history

  7. Remove unused diff from @metamask/accounts-controller patch

    @MajorLift
    MajorLift committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    484be71 View commit details
    Browse the repository at this point in the history

  8. Remove patch for @metamask/keyring-controller@npm:13.0.0

    @MajorLift
    MajorLift committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    00d5e74 View commit details
    Browse the repository at this point in the history

  9. Remove patch for @metamask/keyring-controller@npm:12.2.0

    @MajorLift
    MajorLift committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    cc9d167 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Add TODOs for removing controller-messenger method calls

    @MajorLift
    MajorLift committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    32bc395 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Merge branch 'develop' into 240213-apply-token-detection-controller

    @MajorLift
    MajorLift authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    dc34547 View commit details
    Browse the repository at this point in the history

  2. Define preferencesMessenger and refactor PreferencesController to… 

    … publish `stateChange` events for `setUseTokenDetection`, `setSelectedAddress` calls
    @MajorLift
    MajorLift committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    56eff3f View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. [preferences-controller] Replace manual publish calls with subscripti… 

    …on to observable store
    @MajorLift
    MajorLift committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4f6a160 View commit details
    Browse the repository at this point in the history

  2. Add TODO for preferences-controller migration

    @MajorLift
    MajorLift committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1c374f8 View commit details
    Browse the repository at this point in the history

  3. Remove getNetworkByClientId API callback

    @MajorLift
    MajorLift committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    d6b48c9 View commit details
    Browse the repository at this point in the history

  4. Remove patch for @metamask/accounts-controller

    @MajorLift
    MajorLift committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    b825ed4 View commit details
    Browse the repository at this point in the history

  5. FIx empty SENTRY_BACKGROUND_STATE object for token-detection-contro… 

    …ller
    @MajorLift
    MajorLift committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5f7ae9d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into 240213-apply-token-detection-controller

    @MajorLift
    MajorLift committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    d038ff9 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into 240213-apply-token-detection-controller

    @MajorLift
    MajorLift committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    127ca1d View commit details
    Browse the repository at this point in the history

  8. Fix "working tree dirty" error for lavaomat policies

    @MajorLift
    MajorLift committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    17dde59 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge branch 'develop' into 240213-apply-token-detection-controller

    @MajorLift
    MajorLift authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f98cbad View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into 240213-apply-token-detection-controller

    @MajorLift
    MajorLift authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    0f5db24 View commit details
    Browse the repository at this point in the history