Skip to content

Conversation

@danjm
Copy link
Contributor

@danjm danjm commented Feb 12, 2024

No description provided.

@danjm danjm requested review from a team as code owners February 12, 2024 14:04
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm added the team-extension-platform Extension Platform team label Feb 12, 2024
@danjm danjm changed the base branch from develop to master February 12, 2024 14:04
@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template release-11.9.3 Issue or pull request that will be included in release 11.9.3 labels Feb 12, 2024
@seaona
Copy link
Member

seaona commented Feb 13, 2024

I can see the fix is working 👍 I've noticed some behaviour which might be revised. However, we don't need to fix it in this hot-fix - I could create a separate issue for tackle that if needed

  • With the Balance Checker enabled
    • we show the amount of fees next to the Edit fees icon
    • we show the total fees value duplicated in Fee Details
    • we show an extra vlaue for the total amount which does not seem to add up to anything 🤔 1.0016...

Screenshot from 2024-02-13 10-41-23

  • With the Balance checker disabled we don't show any amount next to the Edit icon
    • we don't show any amount next to the Edit fees icon
    • we don't show any duplicated/extra value in total sections

Screenshot from 2024-02-13 10-41-48

What do you think? cc @bschorchit @danjm

@danjm
Copy link
Contributor Author

danjm commented Feb 13, 2024

With the Balance Checker enabled
we show the amount of fees next to the Edit fees icon
we show the total fees value duplicated in Fee Details
we show an extra vlaue for the total amount which does not seem to add up to anything 🤔 1.0016...

This is the same on v11.9.0, right?

If the balance checker is enabled, the behaviour/displayed information should be the same on this branch as it is on prod. Is that what you are seeing @seaona ?

@seaona
Copy link
Member

seaona commented Feb 13, 2024

correct, I confirm that's a pre-existing behaviour from 11.9 @danjm so definitely no-blocker for the hotfix 👍

@metamaskbot
Copy link
Collaborator

Builds ready [a6e1b78]
Page Load Metrics (779 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint85137104126
domContentLoaded9421573
load7129607796330
domInteractive9421573

@danjm danjm merged commit 9321295 into master Feb 13, 2024
@danjm danjm deleted the Version-v11.9.3 branch February 13, 2024 10:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.9.3 Issue or pull request that will be included in release 11.9.3 team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants