Cherry-picks 7a3d9e2 (#22676) into Version-v11.10.0 #22858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transactions that are being signed are displayed with the `Signing` status in the activity list for additional clarity. The standard `Cancel` button in the activity list will now cancel the signing process for a transaction and mark it as failed. While a transaction is being signed and submitted, subsequent transactions will display an error in the confirmation and the `Confirm` button will be disabled.
danjm
changed the title
danjm
changed the title
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/jsonschema@1.2.4 |
Contributor
|
I don't see any transactions issues related to regression. Transaction can be successfully cancelled from the Activity list when Ledger is disconnected while signing. Also tested with the snap account. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picks 7a3d9e2 (Cancel transaction signing from activity list (#22676)) into Version-v11.10.0
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist